exception during a connector.connect() aren't caught by filters

• Key: DIRMINA-135
• Type: Bug
• Status: Closed
• Resolution: Duplicate
• Priority: Minor
• Assignee: Trustin Lee
• Reporter: Julien Vermillard
• Affects Version/s: 0.8.0, 0.8.1, 0.8.2
• Fix Version/s: 0.9.0

Description

I try to do a reconnection filter, automaticly connecting and reconnecting a connector until it works.
if theinitial connector.connect(...) fail, and exception is thrown, but it's not caught by IoFilter chain. It's not really a bug I think but I added a simple fix :


in SocketConnector class in the connect method :
    public IoSession connect( SocketAddress address, SocketAddress localAddress,

                              int timeout, IoHandler handler ) throws IOException

I changed :

....
        if( request.exception != null )

        {

            ExceptionUtil.throwException( request.exception );

        }

....

into
....
        if( request.exception != null )
        {
        filters.exceptionCaught(null,request.exception );
            ExceptionUtil.throwException( request.exception );
        }
....

and now my filters get the exception normaly, perhaps it's an idea to add it to MINA 0.8 ?

Comments

[Niklas Therning]

A reconnection filter would be great to have. But from what I understand you have a filter which tries to reconnect if the initial connect fails, right? Why not just do this in a while-loop instead?

while (!connected) {
  try {
    connector.connect();
    connected = true;
  } catch (ConnectException ce) {}
}

I think it would be more useful to have a filter which reconnects if an already established connection fails for some reason. And I think that's already possible in MINA 0.8 (if you can live with the blocking connect() call).

Another problem with this approach is that it won't work in MINA 0.9 and beyond. In MINA 0.9 there won't be a filter chain until a session has been created successfully so it won't be possible to call exceptionCaught() on the chain since there simply is no chain.

[Julien Vermillard]

It's how I do actualy I got a Thread for trying to connect the Connector, I tried to implement that in a filter and effectivly it's not really clever, I think my ReconnectionFilter will just try to reconnect disconnected connectors. This issue can be closed.

[Trustin Lee]

You can use a Callback in ConnectFuture instead. IoSession is not created if a connection is not established.

[Julien Vermillard]

ConnectFuture doesn't exist in 0.8 :)