The implementation of LdapName#getSuffix(int) does not match that of Java 1.5's LDAP.

• Key: DIR-112
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Critical
• Assignee: Alex Karasulu
• Reporter: Jacob S. Barrett
• Component/s: miscellaneous

Description

The attached patch fixes the LdapName#getSuffix(int) method to match the one on Java 1.5. The current getSuffix returns a prefix of sorts, but not exactly that of getPrefix. This patch also contains fixes for all (hopefully) places where getSuffix(int) was called. It also corrects the JUnit test. I have also attached a JUnit test that must be compiled and run under Java 1.5 to make sure the naming classes behave the same as Java 1.5's version.

This patch does NOT change the ContextPartion's concet of suffix even though it is really a prefix. So it is called a suffix still, but it is really the prefix.

Comments

[Jacob S. Barrett]

Patch to correct getSuffix.

[Jacob S. Barrett]

Tests Apaching's LdapName against Sun's LdapName for consitency. Depends on Java 1.5.

[Jacob S. Barrett]

Replaces DIRLDAP-37 (http://issues.apache.org/jira/browse/DIRLDAP-37).

[Alex Karasulu]

Sorry can't apply this (really want to though) because it binds us to 1.5 with the test case. All users will have to run builds using the 1.5 jdk. Can you generate the results of using the JDK 1.5 LdapName and use them (generated values) as String based expected values? This way there is no 1.5 dependency and the compilations will work for everyone ;).

[Jacob S. Barrett]

This one replaces the 1.5 results with strings.

[Jacob S. Barrett]

Replaces all other versions of this file. Checks against the com.sun.jndi.ldap.LdapName class in Java 1.4.

[Trustin Lee]

Alex, does your fix include changes in ContextPartition.getSuffix( boolean )? It should be reopen if it doesn't.