[#DERBY-665] Remove backup(File ...) methods

Derby

Remove backup(File ...) methods

Created: 01/Nov/05 02:44 AM Updated: 20/Mar/07 09:54 PM

Return to search

Component/s:

Store

Affects Version/s:

10.2.1.6

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	derby665.diff	2006-01-24 11:30 AM	Suresh Thalamati	10 kB

Environment:

Any

Resolution Date:

29/Jan/06 08:07 AM

Description

« Hide

The code contains backup methods both for specifying the backup directory both as a String and as a File parameter. Only the String versions are currently used. The File versions should be removed to avoid duplication of code etc.
Examples of such methods are:

BasicDatabase.backup
BasicDatabase.backupAndEnableLogArchiveMode
RAMAccessManager.backup
RAMAccessManager.backupAndEnableLogArchiveMode
RawStore.backupAndEnableLogArchiveMode

plus corresponding interfaces.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Suresh Thalamati added a comment - 24/Jan/06 11:30 AM

This patch removes the unused bacpup functions with File as paramteter,
TESTS : derbyall test suite passed on Windows XP/JDK142

It would be great if some can review and commit this patch.

svn stat:
M java\engine\org\apache\derby\impl\db\BasicDatabase.java
M java\engine\org\apache\derby\impl\store\access\RAMAccessManager.java
M java\engine\org\apache\derby\impl\store\raw\RawStore.java
M java\engine\org\apache\derby\iapi\store\access\AccessFactory.java
M java\engine\org\apache\derby\iapi\store\raw\RawStoreFactory.java
M java\engine\org\apache\derby\database\Database.java

[ Permlink | « Hide ]

Suresh Thalamati added a comment - 29/Jan/06 08:07 AM

This issue is fixed in svn commit : r372263