Issue Details (XML | Word | Printable)

Key: DERBY-535
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Kathey Marsden
Reporter: Daniel John Debrunner
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby

Driver.acceptsURL() for embedded driver incorrectly returns true for a client url like jdbc:derby://

Created: 25/Aug/05 01:01 AM   Updated: 20/Mar/07 09:54 PM
Return to search
Component/s: JDBC
Affects Version/s: 10.1.1.0
Fix Version/s: 10.1.2.1, 10.2.1.6

Time Tracking:
Not Specified

File Attachments:
  Size
File Licensed for inclusion in ASF works DERBY535.diff 2005-08-26 05:23 AM Kathey Marsden 9 kB

Resolution Date: 29/Aug/05 09:53 PM


 Description  « Hide
org.apache.derby.jdbc.InternalDriver.acceptsURL will return tru for any URL starting with jdbc:derby: which of course incorrectly includes jdbc:derby://

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Kathey Marsden made changes - 25/Aug/05 11:44 AM
Field Original Value New Value
Assignee Kathey Marsden [ kmarsden ]
Kathey Marsden added a comment - 26/Aug/05 05:23 AM
Added checks to acceptsURL to reject Derby Client and JCC urls.
Added test jdbcapi/checkDriver.java which right now just tests acceptsURL but can be updated to check other Driver methods.
I'll open another Jira entry for this.



Kathey Marsden made changes - 26/Aug/05 05:23 AM
Attachment DERBY535.diff [ 12311978 ]
Repository Revision Date User Message
ASF #240352 Fri Aug 26 22:00:39 UTC 2005 kmarsden DERBY-535 Driver.acceptsURL() for embedded driver incorrectly returns true for
a client url like jdbc:derby://

Changed embedded driver to reject network URL's
Added test for testing driver methods.
Files Changed
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/jdbc/InternalDriver.java
ADD /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/checkDriver.out
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/reference/Attribute.java
ADD /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/checkDriver.java
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/copyfiles.ant

Kathey Marsden added a comment - 27/Aug/05 09:35 AM
Checked into trunk

Author: kmarsden
Date: Fri Aug 26 15:00:39 2005
New Revision: 240352

URL: http://svn.apache.org/viewcvs?rev=240352&view=rev
Log:

DERBY-535 Driver.acceptsURL() for embedded driver incorrectly returns true for
a client url like jdbc:derby://

Changed embedded driver to reject network URL's
Added test for testing driver methods.


Added:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/checkDriver.out (with props)
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/checkDriver.java (with props)
Modified:
    db/derby/code/trunk/java/engine/org/apache/derby/iapi/reference/Attribute.java
    db/derby/code/trunk/java/engine/org/apache/derby/jdbc/InternalDriver.java
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/copyfiles.ant

Modified: db/derby/code/trunk/java/engine/org/apache/derby/iapi/reference/Attribute.java
URL: http://svn.apache.org/viewcvs/db/derby/code/trunk/java/engine/org/apache/derby/iapi/reference/Attribute.java?rev=240352&r1=240351&r2=240352&view=diff

Repository Revision Date User Message
ASF #263981 Mon Aug 29 01:10:44 UTC 2005 kmarsden DERBY-535 Driver.acceptsURL() for embedded driver incorrectly returns true for
a client url like jdbc:derby://

Changed embedded driver to reject network URL's
Added test for testing driver methods.
Files Changed
MODIFY /db/derby/code/branches/10.1/java/engine/org/apache/derby/iapi/reference/Attribute.java
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/copyfiles.ant
ADD /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/checkDriver_app.properties (from /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/checkDriver_app.properties)
ADD /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/checkDriver.java (from /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/checkDriver.java)
MODIFY /db/derby/code/branches/10.1/java/engine/org/apache/derby/jdbc/InternalDriver.java
ADD /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/checkDriver.out (from /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/checkDriver.out)

Kathey Marsden added a comment - 29/Aug/05 09:51 PM
Submitted 263981 for this issue

Kathey Marsden made changes - 29/Aug/05 09:53 PM
Fix Version/s 10.1.1.1 [ 12310155 ]
Fix Version/s 10.2.0.0 [ 11187 ]
Kathey Marsden made changes - 29/Aug/05 09:53 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Deepa Remesh made changes - 30/Sep/05 02:31 AM
Fix Version/s 10.1.1.1 [ 12310332 ]
Kathey Marsden added a comment - 30/Sep/05 02:55 AM
This was checked into 10.1
r263981 | kmarsden | 2005-08-28 18:10:44 -0700 (Sun, 28 Aug 2005) | 7 lines

DERBY-535 Driver.acceptsURL() for embedded driver incorrectly returns true for
a client url like jdbc:derby://

Changed embedded driver to reject network URL's
Added test for testing driver methods.

Andrew McIntyre made changes - 20/Mar/07 09:54 PM
Status Resolved [ 5 ] Closed [ 6 ]