Issue Details (XML | Word | Printable)

Key: DERBY-522
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: A B
Reporter: Kathey Marsden
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby

ERROR X0Y79 raised when adding comments using "--" before sql queries with Network Client

Created: 20/Aug/05 07:19 AM   Updated: 26/Jan/06 01:58 AM
Return to search
Component/s: Network Client
Affects Version/s: 10.1.1.0, 10.1.2.1, 10.2.1.6
Fix Version/s: 10.1.2.1, 10.2.1.6

Time Tracking:
Not Specified

File Attachments:
  Size
Java Source File Licensed for inclusion in ASF works CommentBeforeSelect.java 2005-08-20 07:28 AM Kathey Marsden 5 kB
Text File Licensed for inclusion in ASF works d10_1Master.patch 2005-10-19 08:40 AM A B 1 kB
Text File Licensed for inclusion in ASF works d522_v3.patch 2005-10-15 11:58 PM A B 21 kB
File Licensed for inclusion in ASF works d522_v3.stat 2005-10-15 11:58 PM A B 0.7 kB

Resolution Date: 20/Oct/05 03:56 AM


 Description  « Hide
Comments before a select statement Throws exception with Network Client
For Example a statement like the one below in the attached program with throw an exception.

stmt.execute("-- This is a comment \n Select c11 from TAB1");



org.apache.derby.client.am.SqlException: Statement.executeUpdate() cannot be called with a statement that returns a ResultSet.
        at org.apache.derby.client.am.Statement.completeSqlca(Statement.java:1354)
        at org.apache.derby.client.am.Statement.completeExecuteImmediate(Statement.java:964)
        at org.apache.derby.client.net.NetStatementReply.parseEXCSQLIMMreply(NetStatementReply.java:199)
        at org.apache.derby.client.net.NetStatementReply.readExecuteImmediate(NetStatementReply.java:50)
        at org.apache.derby.client.net.StatementReply.readExecuteImmediate(StatementReply.java:44)
        at org.apache.derby.client.net.NetStatement.readExecuteImmediate_(NetStatement.java:123)
        at org.apache.derby.client.am.Statement.readExecuteImmediate(Statement.java:960)
        at org.apache.derby.client.am.Statement.flowExecute(Statement.java:1587)
        at org.apache.derby.client.am.Statement.executeX(Statement.java:631)
        at org.apache.derby.client.am.Statement.execute(Statement.java:622)
        at CommentBeforeSelect.createAndPopulateTable(CommentBeforeSelect.java:70)
        at CommentBeforeSelect.main(CommentBeforeSelect.java:35)
$
To reproduce run the attached program
java CommentBeforeSelect


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #325993 Mon Oct 17 22:41:03 UTC 2005 kmarsden DERBY-522

1) Updates client to look for statements that begin with comments and to ignore the comments when deciding the kind of statement that is being executed.
2) Changes ij to only strip comments for client versions less than 10.2
3) Adds test cases for statements that begin with comments to the jdbcapi/nullSQLText.java test
4) Updates masters

Contributed by Army Brown
Files Changed
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/forupdate.out
MODIFY /db/derby/code/trunk/java/client/org/apache/derby/client/am/Statement.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
MODIFY /db/derby/code/trunk/java/tools/org/apache/derby/impl/tools/ij/ij.jj
ADD /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/nullSQLText.out
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/nullSQLText.out
ADD /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/nullSQLText.out
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/nullSQLText.java
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/syscat.out

Repository Revision Date User Message
ASF #326222 Tue Oct 18 20:32:10 UTC 2005 kmarsden DERBY-522 - ERROR X0Y79 raised when adding comments using "--" before sql queries with Network Client

merge fix from trunk
svn merge -r 325992:325993 https://svn.apache.org/repos/asf/db/derby/code/trunk

Contributed by Army Brown (qozinx@sbcglobal.net)
Files Changed
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/nullSQLText.out
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/forupdate.out
ADD /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/nullSQLText.out (from /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/nullSQLText.out)
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/nullSQLText.java
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/syscat.out
ADD /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/nullSQLText.out (from /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNet/nullSQLText.out)
MODIFY /db/derby/code/branches/10.1/java/client/org/apache/derby/client/am/Statement.java
MODIFY /db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/sqlgrammar.jj
MODIFY /db/derby/code/branches/10.1/java/tools/org/apache/derby/impl/tools/ij/ij.jj

Repository Revision Date User Message
ASF #326308 Wed Oct 19 00:37:56 UTC 2005 kmarsden DERBY-522 master update to fix lang/forupdate.sql failure in 10.1

Contributed by Army Brown
Files Changed
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/forupdate.out