Issue Details (XML | Word | Printable)

Key: DERBY-504
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Knut Anders Hatlen
Reporter: Knut Anders Hatlen
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby

SELECT DISTINCT returns duplicates when selecting from subselects

Created: 12/Aug/05 06:07 PM   Updated: 11/Jan/07 09:49 AM
Return to search
Component/s: SQL
Affects Version/s: 10.1.2.1
Fix Version/s: 10.1.2.1, 10.2.1.6

Time Tracking:
Not Specified

File Attachments:
  Size
File Licensed for inclusion in ASF works DERBY-504-10.1-unix.diff 2005-09-07 06:27 PM Knut Anders Hatlen 64 kB
File Licensed for inclusion in ASF works DERBY-504-10.1-windows.diff 2005-09-07 06:27 PM Knut Anders Hatlen 65 kB
Text File Licensed for inclusion in ASF works DERBY-504-10.1.stat 2005-09-07 06:27 PM Knut Anders Hatlen 1.0 kB
File Licensed for inclusion in ASF works DERBY-504-cleanup.diff 2005-09-07 06:17 PM Knut Anders Hatlen 2 kB
Text File Licensed for inclusion in ASF works DERBY-504-cleanup.stat 2005-09-07 06:17 PM Knut Anders Hatlen 0.1 kB
File Licensed for inclusion in ASF works DERBY-504.diff 2005-08-28 11:10 PM Knut Anders Hatlen 27 kB
File Licensed for inclusion in ASF works DERBY-504.stat 2005-08-28 11:10 PM Knut Anders Hatlen 0.7 kB
Text File Licensed for inclusion in ASF works DERBY-504_b.diff 2005-08-31 10:16 AM Myrna van Lunteren 65 kB
Text File Licensed for inclusion in ASF works DERBY-504_b.stat 2005-08-31 10:16 AM Myrna van Lunteren 0.9 kB
File Licensed for inclusion in ASF works DERBY-504_c-CRLF.diff 2005-09-02 01:38 AM Knut Anders Hatlen 64 kB
File Licensed for inclusion in ASF works DERBY-504_c-CRLF.diff 2005-09-02 01:35 AM Knut Anders Hatlen 64 kB
File Licensed for inclusion in ASF works DERBY-504_c.diff 2005-09-01 09:19 PM Knut Anders Hatlen 63 kB
Text File Licensed for inclusion in ASF works DERBY-504_c.stat 2005-09-01 09:19 PM Knut Anders Hatlen 0.9 kB
Environment: Latest development sources (SVN revision 232227), Sun JDK 1.5, Solaris/x86
Issue Links:
Dependants
 

Resolution Date: 11/Jan/07 09:49 AM


 Description  « Hide
When one performs a select distinct on a table generated by a subselect, there sometimes are duplicates in the result. The following example shows the problem:

ij> CREATE TABLE names (id INT PRIMARY KEY, name VARCHAR(10));
0 rows inserted/updated/deleted
ij> INSERT INTO names (id, name) VALUES
       (1, 'Anna'), (2, 'Ben'), (3, 'Carl'),
       (4, 'Carl'), (5, 'Ben'), (6, 'Anna');
6 rows inserted/updated/deleted
ij> SELECT DISTINCT(name) FROM (SELECT name, id FROM names) AS n;
NAME
----------
Anna
Ben
Carl
Carl
Ben
Anna

Six names are returned, although only three names should have been returned.

When the result is explicitly sorted (using ORDER BY) or the id column is removed from the subselect, the query returns three names as expected:

ij> SELECT DISTINCT(name) FROM (SELECT name, id FROM names) AS n ORDER BY name;
NAME
----------
Anna
Ben
Carl

3 rows selected
ij> SELECT DISTINCT(name) FROM (SELECT name FROM names) AS n;
NAME
----------
Anna
Ben
Carl

3 rows selected

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #267239 Fri Sep 02 18:07:39 UTC 2005 bandaram DERBY-504: Disable pushing down DISTINCT when number of columns from the parent query and the subquery don't match. Can lead to wrong results.

Thanks to Rick for persistant reviews and running the tests.

Submitted by Knut Anders Hatlen (Knut.Hatlen@Sun.COM)
Files Changed
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/distinct.sql
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/j9_13/distinct.out
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/groupBy.out
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/j9_22/groupBy.out
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/j9_22/distinct.out
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/distinct.out
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ResultColumn.java
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/master/j9_13/groupBy.out
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ResultSetNode.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ProjectRestrictNode.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/SelectNode.java

Repository Revision Date User Message
ASF #306964 Thu Oct 06 23:52:27 UTC 2005 kmarsden DERBY-504
SELECT DISTINCT returns duplicates when selecting from subselects
Merged from trunk with
svn merge -r 267238:267239 https://svn.apache.org/repos/asf/db/derby/code/trunk

Contributed by Knut Anders Hatlen

I (Kathey) also ran j9 tests and updated the j9 masters for changes due to DERBY-392
Files Changed
MODIFY /db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/FromBaseTable.java
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/tests/lang/distinct.sql
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/groupBy.out
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/j9_22/groupBy.out
MODIFY /db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/ResultColumn.java
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/j9_13/groupBy.out
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/j9_13/distinct.out
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/j9_22/distinct.out
MODIFY /db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/SelectNode.java
MODIFY /db/derby/code/branches/10.1/java/testing/org/apache/derbyTesting/functionTests/master/distinct.out
MODIFY /db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/ResultSetNode.java
MODIFY /db/derby/code/branches/10.1/java/engine/org/apache/derby/impl/sql/compile/ProjectRestrictNode.java

Repository Revision Date User Message
ASF #495171 Thu Jan 11 09:47:42 UTC 2007 kahatlen DERBY-504: SELECT DISTINCT returns duplicates when selecting from subselects

Remove redundant check.
Files Changed
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ResultColumnList.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/SelectNode.java