[#DERBY-440] derby.jar has directory (package) entries in it which are not required

Derby

derby.jar has directory (package) entries in it which are not required

Created: 06/Jul/05 02:54 PM Updated: 30/Sep/05 03:02 AM

Return to search

Component/s:

Build tools

Affects Version/s:

10.1.1.0

Fix Version/s:

10.1.2.1, 10.2.1.6

Time Tracking:

Not Specified

Resolution Date:

30/Sep/05 03:02 AM

Description

« Hide

The derby.jar is correctly created by the top-level buil.xml with the attribute filesonly=true.
However the subsequent update of the jar file to add the locale files, partially extracted here, does not include the filesonly attribute, so the directory entries are added in.

around line 757

   <jar destfile="${derby.jar.dir}/derby.jar"
        update="true"
        compress="true">

Adding filesonly="true" to this target solved the problem.

Similar changes are probably needed for the other derby jar files and should be addressed with this bug

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Andrew McIntyre made changes - 15/Jul/05 01:38 PM

Field	Original Value	New Value
Assignee		Andrew McIntyre [ fuzzylogic ]

[ Permlink | « Hide ]

Andrew McIntyre added a comment - 15/Jul/05 01:52 PM

Dan: I was planning on fixing this, since it's so simple, but it looks like you beat me to it with revision 216826. :-)

This should probably be fixed in the 10.1 branch as well, and maybe even 10.0. Would you like me to merge the entire fix for ~~DERBY-419~~ over to 10.1, or should I just fix this particular issue there?

Repository	Revision	Date	User	Message
ASF	#219288	Sat Jul 16 05:15:48 UTC 2005	fuzzylogic	Merge fix for ~~DERBY-440~~ and ~~DERBY-419~~ from trunk.
				Files Changed
				MODIFY /incubator/derby/code/branches/10.1/build.xml

[ Permlink | « Hide ]

Daniel John Debrunner added a comment - 16/Jul/05 06:15 AM

The entire fix for ~~DERBY-419~~ can be moved to 10.1. Sorry, I tried out the quick fix in my codeline and accidently committed it as part of 419. I also wasn't sure if other changes were needed for other jars.
Not sure it is worth putting this in 10.0.

[ Permlink | « Hide ]

Andrew McIntyre added a comment - 16/Jul/05 02:17 PM

Merged fix for ~~DERBY-419~~ and ~~DERBY-440~~ into 10.1 branch with revision 219288.

Andrew McIntyre made changes - 16/Jul/05 02:17 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]
Fix Version/s		10.2.0.0 [ 11187 ]
Fix Version/s		10.1.1.1 [ 12310155 ]

[ Permlink | « Hide ]

Deepa Remesh added a comment - 30/Sep/05 02:14 AM

reopening to fix fix version

Deepa Remesh made changes - 30/Sep/05 02:14 AM

Resolution	Fixed [ 1 ]
Status	Closed [ 6 ]	Reopened [ 4 ]

Deepa Remesh made changes - 30/Sep/05 02:14 AM

Fix Version/s

10.1.1.1 [ 12310332 ]

Deepa Remesh made changes - 30/Sep/05 03:02 AM

Resolution		Fixed [ 1 ]
Status	Reopened [ 4 ]	Closed [ 6 ]