derby.jar has directory (package) entries in it which are not required

• Key: DERBY-440
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Andrew McIntyre
• Reporter: Daniel John Debrunner
• Component/s: Build tools
• Affects Version/s: 10.1.1.0
• Fix Version/s: 10.1.2.1, 10.2.1.6

Description

The derby.jar is correctly created by the top-level buil.xml with the attribute filesonly=true.
However the subsequent update of the jar file to add the locale files, partially extracted here, does not include the filesonly attribute, so the directory entries are added in.

around line 757

   <jar destfile="${derby.jar.dir}/derby.jar"
        update="true"
        compress="true">

Adding filesonly="true" to this target solved the problem.

Similar changes are probably needed for the other derby jar files and should be addressed with this bug

Comments

Dan: I was planning on fixing this, since it's so simple, but it looks like you beat me to it with revision 216826. :-)

This should probably be fixed in the 10.1 branch as well, and maybe even 10.0. Would you like me to merge the entire fix for DERBY-419 over to 10.1, or should I just fix this particular issue there?

[Daniel John Debrunner]

The entire fix for DERBY-419 can be moved to 10.1. Sorry, I tried out the quick fix in my codeline and accidently committed it as part of 419. I also wasn't sure if other changes were needed for other jars.
Not sure it is worth putting this in 10.0.

[Andrew McIntyre]

Merged fix for DERBY-419 and DERBY-440 into 10.1 branch with revision 219288.

[Deepa Remesh]

reopening to fix fix version