Improve handling of the database temporary directory

• Key: DERBY-4093
• Type: Sub-task
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Kristian Waagan
• Reporter: Kristian Waagan
• Component/s: Store
• Affects Version/s: 10.5.1.1
• Fix Version/s: 10.5.1.1

Description

The problem reported by Knut Anders Hatlen in DERBY-646 is caused by improper handling of the temporary directory created for the database.
A NullPointerException was thrown on database shutdown.

After studying the code, I believe it is wise to follow the approach taken by the base storage factory;
 o locate the temporary directory within the database directory
    (i.e. for database 'mydb' this will by 'mydb/tmp')
 o don't create the temporary directory before Derby supplies a unique name to the storage factory

Comments

[Kristian Waagan]

Patch 1a fixes the improper handling of the temporary database directory.
The directory will always be created as <database_directory>/tmp
Added two tests, one for database shutdown and one for engine shutdown.

I'm committing this patch ASAP, but feel free to still comment on it.

[Kristian Waagan]

Patch 1b contains a few changes to the tests (make sure tests fail if exception on shutdown isn't thrown, and reload the engine code after engine shutdown).

[Kristian Waagan]

Committed patch 1b to trunk with revision 753239.
Keeping the issue open for a while to handle any problems and address comments.

[Knut Anders Hatlen]

Thanks, I don't see the NPE now.