Issue Details (XML | Word | Printable)

Key: DERBY-3972
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Myrna van Lunteren
Reporter: Kathey Marsden
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby

Update test harness to run with DesktopEE JRE

Created: 03/Dec/08 05:21 PM   Updated: 04/May/09 06:22 PM
Component/s: Test
Affects Version/s: 10.3.3.0, 10.4.1.3, 10.5.1.1
Fix Version/s: 10.5.1.1

Time Tracking:
Not Specified

File Attachments:
  File Name Date Attached Attached By Size
File Licensed for inclusion in ASF works DERBY-3972_part1.diff 2009-01-27 11:35 PM Myrna van Lunteren 9 kB
Text File Licensed for inclusion in ASF works DERBY-3972_part1.diff2 2009-01-28 07:36 PM Myrna van Lunteren 9 kB
File Licensed for inclusion in ASF works DERBY-3972_part2.diff 2009-02-02 07:14 PM Myrna van Lunteren 2 kB
File Licensed for inclusion in ASF works DERBY-3972_part3.diff 2009-02-04 11:29 PM Myrna van Lunteren 3 kB

Resolution Date: 17/Feb/09 04:59 PM


 Description  « Hide
IBM's Lotus Expeditor (http://www-01.ibm.com/software/lotus/products/expeditor/) includes the DesktopEE JRE which is described as:

"The default Java™ Runtime Environment (JRE) of Lotus Expeditor is IBM's J9 VM with the DesktopEE class libraries, an IBM-optimized subset of Java 5 that offers a smaller footprint and faster class loading than standard Java Runtime Environments."

My understanding is that it is a superset of JDK 1.4, so should run fine with Derby. The test harness needs to be updated to recognize this JVM so we can test with it.

See
http://publib.boulder.ibm.com/infocenter/ledoc/v6r2/topic/com.ibm.rcp.tools.doc.appdev/devapps_developingwiththejcldesktopjre.html for more information on DesktopEE.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Kathey Marsden made changes - 03/Dec/08 05:22 PM
Field Original Value New Value
Description IBM's Lotus Expeditor (http://www-01.ibm.com/software/lotus/products/expeditor/) includes the DesktopEE JRE which is described as:

"The default Java™ Runtime Environment (JRE) of Lotus Expeditor is IBM's J9 VM with the DesktopEE class libraries, an IBM-optimized subset of Java 5 that offers a smaller footprint and faster class loading than standard Java Runtime Environments."

My understanding is that it is a superset of JDK 1.4, so should run fine with Derby. The test harness needs to be updated to recognize this JVM so we can test with it.

See
http://publib.boulder.ibm.com/infocenter/ledoc/v6r2/topic/com.ibm.rcp.tools.doc.appdev/devapps_developingwiththejcldesktopjre.html for more information on DesktopEE.
Environment IBM's Lotus Expeditor (http://www-01.ibm.com/software/lotus/products/expeditor/) includes the DesktopEE JRE which is described as:

"The default Java™ Runtime Environment (JRE) of Lotus Expeditor is IBM's J9 VM with the DesktopEE class libraries, an IBM-optimized subset of Java 5 that offers a smaller footprint and faster class loading than standard Java Runtime Environments."

My understanding is that it is a superset of JDK 1.4, so should run fine with Derby. The test harness needs to be updated to recognize this JVM so we can test with it.

See
http://publib.boulder.ibm.com/infocenter/ledoc/v6r2/topic/com.ibm.rcp.tools.doc.appdev/devapps_developingwiththejcldesktopjre.html for more information on DesktopEE.
Myrna van Lunteren made changes - 14/Jan/09 09:39 PM
Assignee Kathey Marsden [ kmarsden ] Myrna van Lunteren [ myrna ]
[ Permlink | « Hide ]
Myrna van Lunteren added a comment - 27/Jan/09 11:35 PM
attaching a patch for this issue that addresses adding the necessary jvm subclass to the old test harness and causing the encryptionOFB tests to skip with this jvm (as the algorithm isn't supported with it).

Myrna van Lunteren made changes - 27/Jan/09 11:35 PM
Attachment DERBY-3972_part1.diff [ 12398855 ]
Myrna van Lunteren made changes - 27/Jan/09 11:36 PM
Derby Info [Patch Available]
[ Permlink | « Hide ]
Kathey Marsden added a comment - 28/Jan/09 07:01 PM
Hi Myrna,

The patch looks good except for a stray System.out.println in FileCompare and an indentation issue in RunSuite near line 106.

[ Permlink | « Hide ]
Myrna van Lunteren added a comment - 28/Jan/09 07:36 PM
Thanks for the review Kathey! Attaching an updated patch that addresses these points.

Myrna van Lunteren made changes - 28/Jan/09 07:36 PM
Attachment DERBY-3972_part1.diff2 [ 12398921 ]
Repository Revision Date User Message
ASF #738671 Wed Jan 28 23:29:24 UTC 2009 myrnavl DERBY-3972; committing patch part1.diff2 for initial support in test harness
  for ibm's desktopEE jvm
Files Changed
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/harness/RunTest.java
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/harness/FileCompare.java
ADD /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/harness/j9dee15.java
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/harness/RunSuite.java
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/harness/RunList.java
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/suites/encryptionOFB.properties

[ Permlink | « Hide ]
Myrna van Lunteren added a comment - 28/Jan/09 11:31 PM
committed part1.diff2 with revision 738671.

More work is needed: currently no network server tests get run. Also some modifications are needed to the junit framework.

Myrna van Lunteren made changes - 28/Jan/09 11:31 PM
Derby Info [Patch Available]
[ Permlink | « Hide ]
Myrna van Lunteren added a comment - 02/Feb/09 07:14 PM
Making some changes to the runwith (il)logic so runwithj9=false doesn't apply to j9dee15 enables the network server tests.

If there are no comments I'll commit this tomorrow.

Myrna van Lunteren made changes - 02/Feb/09 07:14 PM
Attachment DERBY-3972_part2.diff [ 12399288 ]
Repository Revision Date User Message
ASF #740313 Tue Feb 03 14:34:09 UTC 2009 myrnavl DERBY-3972 - patch part2, enabling desktopEE to run tests flagged with
  with runwithj9=false, such as network server tests.
Files Changed
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/harness/RunList.java

[ Permlink | « Hide ]
Myrna van Lunteren added a comment - 04/Feb/09 11:29 PM
The ldap tests failed with DesktopEE because it's using a different initial context factory. I've added another optional property - derbyTesting.ldapContextFactory - to enable running the ldap tests with this.
The tests will not run differently from before unless you specify the property - they'll default to using the sun factory.
If there are no complaints I'll commit tomorrow.

Myrna van Lunteren made changes - 04/Feb/09 11:29 PM
Attachment DERBY-3972_part3.diff [ 12399492 ]
Repository Revision Date User Message
ASF #741227 Thu Feb 05 18:42:27 UTC 2009 myrnavl DERBY-3972; patch 3 modifies 2 tests to optionally take a property for
  a different initial context factory than sun's
Files Changed
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/LDAPAuthenticationTest.java
MODIFY /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/XAJNDITest.java

[ Permlink | « Hide ]
Myrna van Lunteren added a comment - 17/Feb/09 04:59 PM
Done all I intend to do on this.

Myrna van Lunteren made changes - 17/Feb/09 04:59 PM
Resolution Fixed [ 1 ]
Fix Version/s 10.5.0.0 [ 12313010 ]
Status Open [ 1 ] Closed [ 6 ]
Myrna van Lunteren made changes - 04/May/09 06:22 PM
Fix Version/s 10.5.0.0 [ 12313010 ]
Fix Version/s 10.5.1.1 [ 12313771 ]
Affects Version/s 10.5.0.0 [ 12313010 ]
Affects Version/s 10.5.1.1 [ 12313771 ]

Powered by a free Atlassian JIRA open source license for Apache Software Foundation. Try JIRA - bug tracking software for your team.
Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.2-#335) - Bug/feature request - Atlassian news - Contact Administrators