Don't allow references to generated columns in the NEW transition variables of triggered actions of BEFORE triggers

• Key: DERBY-3948
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Rick Hillegas
• Component/s: SQL
• Affects Version/s: 10.5.1.1
• Fix Version/s: 10.5.1.1

Description

Thanks to Dag for finding this restriction in the SQL Standard, part 2, section 11.39, SR 12 c) I see this provision:

   12) If BEFORE is specified, then:
     :
     c) The <triggered action> shall not contain a <field reference> that
     references a field in the new transition variable corresponding to a
     generated column of T.

Comments

[Rick Hillegas]

Attaching derby-3948-01-aa-beforeTriggers.diff. This enforces the rule that generated columns can't be mentioned in the NEW variables of actions fired by BEFORE triggers. Tests are running now.

Touches the following files:

M java/engine/org/apache/derby/impl/sql/compile/CreateTriggerNode.java

Adds method to look for the offending references.


M java/engine/org/apache/derby/loc/messages.xml
M java/shared/org/apache/derby/shared/common/reference/SQLState.java

Adds an error message to flag this forbidden condition.


M java/testing/org/apache/derbyTesting/functionTests/tests/lang/GeneratedColumnsTest.java
M java/testing/org/apache/derbyTesting/functionTests/tests/lang/GeneratedColumnsHelper.java

Adds regression tests. Also changes a couple pre-existing test cases because they violated this rule.

[Rick Hillegas]

Tests ran cleanly for me. Committed derby-3948-01-aa-beforeTriggers.diff at subversion revision 718707.