Issue Details (XML | Word | Printable)

Key: DERBY-3576
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Kristian Waagan
Reporter: Kristian Waagan
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby
DERBY-3575

Merge EngineBlob and EngineClob into a single interface

Created: 28/Mar/08 07:59 AM   Updated: 04/May/09 06:22 PM
Return to search
Component/s: Network Server
Affects Version/s: 10.4.1.3, 10.5.1.1
Fix Version/s: 10.3.3.0, 10.4.1.3, 10.5.1.1

Time Tracking:
Not Specified

File Attachments:
  Size
File Licensed for inclusion in ASF works derby-3576-1a-enginelob_interface.diff 2008-03-28 08:16 AM Kristian Waagan 9 kB
File Licensed for inclusion in ASF works derby-3576-1a-enginelob_interface.stat 2008-03-28 08:16 AM Kristian Waagan 0.5 kB
File Licensed for inclusion in ASF works derby-3576-1b-enginelob_interface.diff 2008-03-30 10:57 AM Kristian Waagan 9 kB

Resolution Date: 30/Mar/08 11:15 AM


 Description  « Hide
There are currently two identical interfaces called EngineBlob and EngineClob.
Merging these into a single interface would simplify some of the code handling Blob and Clob in the network server, and it also allows a leaner implementation of a stored procedure freeing LOB locators without knowing if the locator represents a Blob or a Clob.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #642707 Sun Mar 30 11:09:05 UTC 2008 kristwaa DERBY-3576: Merge EngineBlob and EngineClob into a single interface.
Merged the two interfaces and added the method 'free'. There was no need to sepearate between a Blob and a Clob where the interface was used. If such a need arises, one should consider adding new interfaces extending EngineLOB.
Patch file: DERBY-3576-1b-enginelob_interface.diff
Files Changed
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/LOBStoredProcedure.java
ADD /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/EngineLOB.java
DEL /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/EngineBlob.java
DEL /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/EngineClob.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java
MODIFY /db/derby/code/trunk/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/EmbedClob.java

Repository Revision Date User Message
ASF #642711 Sun Mar 30 11:15:12 UTC 2008 kristwaa DERBY-3576: Merge EngineBlob and EngineClob into a single interface.
Merged change from trunk revision 642707 (DERBY-3576-1b-enginelob_interface.diff).
Files Changed
MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/impl/jdbc/LOBStoredProcedure.java
ADD /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/EngineLOB.java (from /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/EngineLOB.java)
DEL /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/EngineBlob.java
DEL /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/EngineClob.java
MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java
MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java
MODIFY /db/derby/code/branches/10.4/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java
MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/impl/jdbc/EmbedClob.java

Repository Revision Date User Message
ASF #643326 Tue Apr 01 09:02:21 UTC 2008 kristwaa DERBY-3576: Fixed JavaDoc warning.
Patch file: n/a
Files Changed
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/EngineLOB.java

Repository Revision Date User Message
ASF #643328 Tue Apr 01 09:08:15 UTC 2008 kristwaa DERBY-3576: Fixed JavaDoc warning.
Merged revision 643326 from trunk.
Files Changed
MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/EngineLOB.java

Repository Revision Date User Message
ASF #652087 Tue Apr 29 20:25:00 UTC 2008 kmarsden DERBY-2885 Cleanup of EmbedConnection.clearLOBMapping():
revision 552325
Contributed by Knut Anders Hatlen

DERBY-3576 Merge EngineBlob and EngineClob into a single interface
revision 642707
Contributed by Kritian Waagan.

DERBY-3354 Select from large lob table with embedded gives OutOfMemoryError
revision 644755, 644764
Contributed by Anurag Shekhar
Files Changed
ADD /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/EngineLOB.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/jdbc/LOBStoredProcedure.java
DEL /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/EngineBlob.java
DEL /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/EngineClob.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/jdbc/EmbedBlob.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/jdbc/EmbedClob.java
MODIFY /db/derby/code/branches/10.3/java/drda/org/apache/derby/impl/drda/DRDAConnThread.java

Repository Revision Date User Message
ASF #652605 Thu May 01 18:18:11 UTC 2008 kmarsden DERBY-3576 fix javadoc warning.
Files Changed
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/EngineLOB.java