[#DERBY-3525] Remove unneeded code to get JDBC level in BrokeredConnection and BrokeredStatement classes

Derby

Remove unneeded code to get JDBC level in BrokeredConnection and BrokeredStatement classes

Created: 12/Mar/08 11:11 AM Updated: 04/May/09 06:22 PM

Return to search

Component/s:

JDBC

Affects Version/s:

10.5.1.1

Fix Version/s:

10.3.3.0, 10.4.1.3, 10.5.1.1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	derby-3525_diff.txt	2008-03-12 06:38 PM	Kathey Marsden	11 kB

Issue Links:

Reference

This issue is related to:

~~DERBY-3513~~ NullPointerException in newBrokeredStatement in app server environment

Resolution Date:

19/Mar/08 05:14 PM

Description

« Hide

BrokeredConnection has a method called getJDBCLevel() whose only purpose is to provide a value that can be stored in BrokeredStatement.jdbcLevel. This field is only used once, in BrokeredStatement.createDuplicateStatement():

if (jdbcLevel == 2)
newStatement = conn.createStatement(resultSetType, resultSetConcurrency);
else
newStatement = conn.createStatement(resultSetType, resultSetConcurrency,
resultSetHoldability);

Since getJDBCLevel() only returns 2 if Java version 1.3 is used, and Derby doesn't support Java 1.3 any more, BrokeredConnection.getJDBCLevel() and BrokeredStatement.jdbcLevel could be removed.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#636753	Thu Mar 13 13:09:37 UTC 2008	kmarsden	~~DERBY-3525~~ Remove unneeded code to get JDBC level in BrokeredConnection and BrokeredStatement classes
				Files Changed
				MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement30.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement40.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredStatement.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement30.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement40.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredStatement40.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection30.java MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection40.java

Repository	Revision	Date	User	Message
ASF	#638931	Wed Mar 19 16:41:56 UTC 2008	kmarsden	~~DERBY-3525~~ Remove unneeded code to get JDBC level in BrokeredConnection and BrokeredStatement classes port from trunk revision 636753
				Files Changed
				MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement30.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement40.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredStatement.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement30.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement40.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredStatement40.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection30.java MODIFY /db/derby/code/branches/10.4/java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection40.java

Repository	Revision	Date	User	Message
ASF	#638939	Wed Mar 19 17:14:54 UTC 2008	kmarsden	~~DERBY-3525~~ Remove unneeded code to get JDBC level in BrokeredConnection and BrokeredStatement classes port revision 636753 from trunk
				Files Changed
				MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection40.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement30.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement40.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredStatement.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement30.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredPreparedStatement40.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredStatement40.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection30.java MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/jdbc/BrokeredCallableStatement.java