CallableStatement with output parameter leaves cursor open after execution

• Key: DERBY-3496
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Dyre Tjeldvoll
• Reporter: Knut Anders Hatlen
• Component/s: JDBC
• Affects Version/s: 10.4.1.3
• Fix Version/s: 10.3.3.0, 10.4.1.3

Description

When executing a CallableStatement which has an output parameter, the language result set is left open and makes subsequent calls to Connection.setTransactionIsolation() fail with "ERROR X0X03: Invalid transaction state - held cursor requires same isolation level".

Comments

[Knut Anders Hatlen]

The attached patch (junit-repro.diff) adds a test case to jdbcapi/CallableTest which fails in both embedded and client/server mode.

$ java junit.textui.TestRunner org.apache.derbyTesting.functionTests.tests.jdbcapi.CallableTest
....E.............E.........
Time: 6.071
There were 2 errors:
1) testIsolationLevelChangeAfterFunctionCall(org.apache.derbyTesting.functionTests.tests.jdbcapi.CallableTest)java.sql.SQLException: Invalid transaction state - held cursor requires same isolation level
....
2) testIsolationLevelChangeAfterFunctionCall(org.apache.derbyTesting.functionTests.tests.jdbcapi.CallableTest)java.sql.SQLException: Invalid transaction state - held cursor requires same isolation level
....

[Knut Anders Hatlen]

If the CallableStatement is closed before the isolation level is changed, it works in embedded mode, but it still fails the same way in client/server mode.

[Dyre Tjeldvoll]

Adding 10.3.2.2 and 10.4.0.0 as fix versions as it looks like a candidate for merging to 10.3

[Dyre Tjeldvoll]

Attaching derby-3496.diff which incorporates the new test case attached earlier.

[Knut Anders Hatlen]

The fix looks correct to me, but the new line in EmbedCallableStatement is not indented correctly (probably due to incorrect tab size setting in your IDE).

[Dyre Tjeldvoll]

Committed revision 640787.

I did fix the indentation problem before committing. The "IDE" in question is 'vi'. :set hardtabs=4 (perhaps followed by :set autoindent) appears to be the magic words.

[Dyre Tjeldvoll]

Need to merge it to release branch

[Dyre Tjeldvoll]

Merged to 10.4 in revision 640801.

[Dyre Tjeldvoll]

Merged to 10.3 with revision 640808.