[#DERBY-3426] Remove unused code for autogenerated keys columnNames

Derby

DERBY-2653

Remove unused code for autogenerated keys columnNames

Created: 16/Feb/08 10:27 PM Updated: 20/Feb/08 10:43 PM

Return to search

Component/s:

Network Client

Affects Version/s:

10.3.3.0, 10.4.1.3

Fix Version/s:

10.3.3.0, 10.4.1.3

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
derby-3426_diff.txt	2008-02-17 08:09 PM	Kathey Marsden	8 kB
derby-3426_diff2.txt	2008-02-18 12:14 AM	Kathey Marsden	9 kB

Issue & fix info:	Patch Available
Resolution Date:	18/Feb/08 03:20 PM

Description

« Hide

There is unused code for autogenerated keys that processes columnNames by flowing a select from final table statement to the server. This syntax is not supported or used by Derby and should be removed from client.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Kathey Marsden added a comment - 17/Feb/08 08:09 PM

Attached is a patch to remove the unused code for autogenerated keys with columnNames. I ran suites.All and derbynetclientmats with jdk16.

Kathey Marsden made changes - 17/Feb/08 08:09 PM

Field	Original Value	New Value
Attachment		derby-3426_diff.txt [ 12375802 ]

[ Permlink | « Hide ]

Kathey Marsden added a comment - 17/Feb/08 09:40 PM

I found a problem with the derby-3426_diff.txt patch. Please ignore.

[ Permlink | « Hide ]

Kathey Marsden added a comment - 18/Feb/08 12:14 AM

Attached is derby-3426_diff2.txt which has the code removed. The original patch had a stray else left in the removed code. It is surprising it worked as well as it did #:) Ran suites.All and derbynetclientmats with the new patch.

Kathey Marsden made changes - 18/Feb/08 12:14 AM

Attachment

derby-3426_diff2.txt [ 12375805 ]

Kathey Marsden made changes - 18/Feb/08 12:14 AM

Derby Info

[Patch Available]

Repository	Revision	Date	User	Message
ASF	#628780	Mon Feb 18 15:20:26 UTC 2008	kmarsden	~~DERBY-3426~~ Remove unused code for autogenerated keys columnNames
				Files Changed
				MODIFY /db/derby/code/trunk/java/client/org/apache/derby/client/am/Statement.java MODIFY /db/derby/code/trunk/java/client/org/apache/derby/client/am/PreparedStatement.java

Kathey Marsden made changes - 18/Feb/08 03:20 PM

Fix Version/s		10.4.0.0 [ 12312540 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

Repository	Revision	Date	User	Message
ASF	#629637	Wed Feb 20 22:21:14 UTC 2008	kmarsden	~~DERBY-3426~~ Remove unused code for autogenerated keys columnNames merge from trunk revision 628780
				Files Changed
				MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/am/Statement.java MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/am/PreparedStatement.java

Kathey Marsden made changes - 20/Feb/08 10:38 PM

Affects Version/s

10.3.2.2 [ 12312885 ]

Kathey Marsden made changes - 20/Feb/08 10:43 PM

Fix Version/s

10.3.2.2 [ 12312885 ]