Remove unused code for caching of connect bytes

• Key: DERBY-3421
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Kristian Waagan
• Reporter: Kristian Waagan
• Component/s: Network Client
• Affects Version/s: 10.3.2.1, 10.4.1.3
• Fix Version/s: 10.3.3.0, 10.4.1.3

Description

The client driver has code for caching connect bytes, but it is not used.
This unused code clutters the rest of the code and makes it harder to understand.

Secondly, the variable used to determine if the cached connect bytes can be used is public in am.Connection.

If someone has historic information about this feature, it would be nice if they could add the information to this Jira.

Comments

[Kristian Waagan]

'derby-3421-1a-removal.diff' removes the code related to caching of connect bytes.
I'm running tests for good measure.

If someone think this is an important feature, please create a new Jira for enabling it and close this one as invalid.
I will wait for a little while before I commit the patch.


thanks,

[Kristian Waagan]

Tests ran fine with the patch applied (Solaris 10, Sun JDK 1.6).

[Knut Anders Hatlen]

+1 to commit. It doesn't sound like an important feature, and if someone thinks it is, they can always get the code back from svn and do what it takes to enable it. Since it's not used now, it's better to remove it so that the code is easier to understand.

I think you can also remove NetConnectionReply.verifyDeferredReset() since you removed the only code that calls it.

[Kristian Waagan]

Thanks for catching the other method that can be removed Knut Anders.

'derby-3421-1b-removal.diff' removes NetConnectionReply.verifyDeferredReset as well, nothing else is changed.

[Kristian Waagan]

Committed 'derby-3421-1b-removal.diff' to trunk with revision 628679.
I don't expect more work to be done on this issue.

[Kathey Marsden]

Committed revision 651835 to 10.3