[#DERBY-3421] Remove unused code for caching of connect bytes

Derby

Remove unused code for caching of connect bytes

Created: 15/Feb/08 02:23 PM Updated: 26/Apr/08 03:37 PM

Return to search

Component/s:

Network Client

Affects Version/s:

10.3.2.1, 10.4.1.3

Fix Version/s:

10.3.3.0, 10.4.1.3

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
derby-3421-1a-removal.diff	2008-02-15 03:36 PM	Kristian Waagan	10 kB
derby-3421-1a-removal.stat	2008-02-15 03:36 PM	Kristian Waagan	0.1 kB
derby-3421-1b-removal.diff	2008-02-18 10:54 AM	Kristian Waagan	11 kB
derby-3421-1b-removal.stat	2008-02-18 10:54 AM	Kristian Waagan	0.2 kB

Issue Links:

dependent

This issue is depended upon by:

~~DERBY-3379~~ "No Current connection" on PooledConnection.getConnection() if pooled connection is reused during connectionClosed processing

Resolution Date:

18/Feb/08 10:57 AM

Description

« Hide

The client driver has code for caching connect bytes, but it is not used.
This unused code clutters the rest of the code and makes it harder to understand.

Secondly, the variable used to determine if the cached connect bytes can be used is public in am.Connection.

If someone has historic information about this feature, it would be nice if they could add the information to this Jira.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#628679	Mon Feb 18 10:56:23 UTC 2008	kristwaa	~~DERBY-3421~~: Remove unused code for caching of connect bytes. Patch file: ~~DERBY-3421~~-1b-removal.diff
				Files Changed
				MODIFY /db/derby/code/trunk/java/client/org/apache/derby/client/am/Connection.java MODIFY /db/derby/code/trunk/java/client/org/apache/derby/client/net/NetConnection.java MODIFY /db/derby/code/trunk/java/client/org/apache/derby/client/net/NetConnectionReply.java

Repository	Revision	Date	User	Message
ASF	#651835	Sat Apr 26 15:39:30 UTC 2008	kmarsden	~~DERBY-3379~~ "No Current connection" on PooledConnection.getConnection() if pooled connection is reused during connectionClosed ported revision 637805,642942 ~~DERBY-3421~~ Remove unused code for caching of connect bytes revision 628679 Contributed by Kritian Waagan ( Kristian dot Waagan at Sun dot com)
				Files Changed
				MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/am/Connection.java MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/net/Request.java MODIFY /db/derby/code/branches/10.3/java/testing/org/apache/derbyTesting/functionTests/tests/jdbc4/DataSourceTest.java MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/ClientPooledConnection.java MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/net/NetConnection.java MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/net/NetConnectionReply.java