Network Server stores a duplicate entry in the lob hash map for every lob

• Key: DERBY-3365
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Kathey Marsden
• Reporter: Kathey Marsden
• Component/s: Network Server
• Fix Version/s: 10.3.3.0, 10.4.1.3

Description

Per discussion in DERBY-3243, Network Server stores a duplicate entry in the lob hashmap for every lob. I posted a preliminary patch to DERBY-3243 and received comments on the patch in that issue, but it makes more sense to separate the issue out from DERBY-3243. So opening up this new issue.

Comments

[Kathey Marsden]

Early patch and discussion is in DERBY-3243

[Kathey Marsden]

Attached is a follow-up patch derby-3365_diff.txt incorporating review comments from my patch attached to DERBY-3243
(derby-3243_fix_double_hashmap_entry_diff.txt)
I'm sorry Knut I missed your original post about the patch.
Hopefully all the changes are in this time. For this revision I fixed the typos and changed the lob create stored procedures to use getLocator().


I did not move the addlobLocator call to getLocator() because it would cause a regression for the DERBY-2787 fix. I will leave any optimization in this area to the DERBY-3354 fix.

[Knut Anders Hatlen]

Looks fine to me. In BrokeredConnection, you should also remove the javadoc comment for addLOBMapping().

I'm wondering, should EngineBlob and EngineClob have been in iapi.jdbc rather than impl.jdbc? That's where the rest of the engine interfaces are located.

[Kathey Marsden]

Thanks Knut for looking at the patch. You are right about EngineClob and EngineBlob. Not sure how I managed to make them where I did, a matter of Eclipse making things too easy I think. I moved them before I committed.

[Knut Anders Hatlen]

Thanks Kathey. I noticed that the commit log looked a bit odd for this check-in. It says that EmbedBlob.java was added, and lists the entire file with plus lines in the diff. Do you know what happened?

[Knut Anders Hatlen]

Hmm, I guess your IDE or something must have tricked you into replacing (that is, removing + adding) EmbedBlob.java rather than modifying it. I managed to restore the file history by this sequence of commands:

$ cd java/engine/org/apache/derby/impl/jdbc
$ cp EmbedBlob.java EmbedBlob.java.old
$ svn remove EmbedBlob.java
$ svn copy -r 617185 EmbedBlob.java .
$ cp EmbedBlob.java.old EmbedBlob.java
$ svn ci

Now "svn annotate" shows the correct information, and not that all lines were changed by kmarsden in revision 617186. Hope I didn't break anything in the process...

[Kathey Marsden]

Thanks Knut for fixing that up.

[Kathey Marsden]

committed change to 10.3 and trunk.