Minor cleanups in ClientPooledConnection40 and ClientPooledConnection

• Key: DERBY-3309
• Type: Sub-task
• Status: Closed
• Resolution: Fixed
• Priority: Trivial
• Assignee: Kristian Waagan
• Reporter: Kristian Waagan
• Component/s: JDBC, Network Client
• Affects Version/s: 10.2.2.0, 10.3.2.1, 10.4.1.3
• Fix Version/s: 10.2.2.1, 10.3.3.0, 10.4.1.3

Description

A few minor cleanups:
 1) Remove unused constructor
 2) Remove unused imports
 3) Various documentation/formatting fixes

Other minor fixes will be done if required.

Comments

[Kristian Waagan]

'derby-3309-1a-unused_imports.diff' removes unused imports from ClientPooledConnection40.

Committed to trunk with revision 610404.
Merged to 10.3 with revision 610766.
Merged to 10.2 with revision 610767.

[Kristian Waagan]

'derby-3309-2a-remove_unused_constructor.diff' removes an unused contructor in ClientPooledConnection and ClientPooledConnection40. I traced it back to when the client driver was donated/added, so I have no idea why it was once introduced.

If anyone has information that indicates that it should not be removed, please let me know.

[Dyre Tjeldvoll]

Fwiw, I was under the impression that users are supposed use a DataSource implementation to interact with a connection pool, so I cannot see any reason why the driver should provide these constructors if it does not use them internally. +1

[Kristian Waagan]

Thanks for the comment Dyre.

I committed 'derby-3309-2a-remove_unused_constructor.diff' to trunk with revision 611841.
I also decided that these fixes should not be ported to older brances, as the wiki page describing the process says that in general only bug-fixes should be back-ported (see http://wiki.apache.org/db-derby/MoveAChangeBetweenBranches).
I do not plan to back out the removal of unused imports from 10.2 and 10.3 though.

If someone has comments or another view on the porting issue, let me know.

[Kristian Waagan]

'derby-3309-3a-cpc_documentation_changes.diff' changes and adds some documentation for ClientPooledConnection.

Would be nice if someone read through it before I commit.

[Kristian Waagan]

Committed 'derby-3309-3a-cpc_documentation_changes.diff' to trunk with revision 615846.

[Kristian Waagan]

'derby-3309-4a-cpc_listeners_synch.diff' replaces a Vector with an ArrayList and fixes the broken synchronization of the list of event listeners in ClientPooledConnection.
I have run derbyall and suites.All (Java 1.4.2 and Java SE 5.0) without errors.

I'm observing that in CPC a new event object is created for each listener, whereas in CPC40 the same object is reused for all listeners.

Patch ready for review.

[Kristian Waagan]

Committed 'derby-3309-4a-cpc_listeners_synch.diff' to trunk with revision 620485.

Since DERBY-3308 was backported, I plan to see if I can backport the patches for this issue as well.
I want to wait for a little while to see if any problems show up.

[Kristian Waagan]

Merged patches 'derby-3309-2a-remove_unused_constructor.diff', 'derby-3309-3a-cpc_documentation_changes.diff' and 'derby-3309-4a-cpc_listeners_synch.diff' to branches 10.2 and 10.3.
I ran derbyall and/or suites.All for both branches.
Committed to 10.3 with revision 630185.
Committed to 10.2 with revision 630186.

Marking fixed, awaiting daily test run results to verify no tests are failing before closing.

[Kristian Waagan]

No problems reported.