Activation for a dynamic ResultSet created from an Prepared/CallableStatement will not be closed until garbage collection indicates it is unused to the LCC and the LCC closes it

• Key: DERBY-3247
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Daniel John Debrunner
• Reporter: Daniel John Debrunner
• Component/s: JDBC
• Affects Version/s: 10.3.1.4, 10.4.1.3
• Fix Version/s: 10.3.3.0, 10.4.1.3

Description

In a Java procedure called from SQL any dynamic ResultSets that are created using a PreparedStatement or CallableStatement leave their activations open until :
   - the statement that created it is garbage collected (which requires the outer statement to be garbage collected)
   - and the LCC processes unused Activations.

Dynamic ResultSets that are created by a Statement object are handled correctly because they are marked single use activation and thus the close of the ResultSet also closes the activation.

Fix is to mark the activation as single use in EmbedResultSet when the EmbedResultSet is marked as being a dynamic ResultSet. This will then lead to the close of the ResultSet also closing the activation.

Can't see how to write a test for this, I can see the activations stacking up in a debugger, but typically there will be no visible user impact.

Comments

[Daniel John Debrunner]

Patch that marks an Activation for a dynamic EmbedResultSet as single use to ensure it is closed when the ResultSet is closed.

Also add some comments to EmbedStatement.finalize() that indicate it's ok not to handle the result sets in dynamicResults.

Will run tests on the patch but expect them to succeed since this is only moving a close earlier.

[Daniel John Debrunner]

Revision: 601386 applied to trunk.

[Daniel John Debrunner]

To marked fixed in 10.3

[Daniel John Debrunner]

Revision: 610895 in 10.3 branch.