[#DERBY-3037] Language ResultSet.finish() is called even when the ResultSet is going to be re-used.

Derby

Language ResultSet.finish() is called even when the ResultSet is going to be re-used.

Created: 31/Aug/07 11:40 PM Updated: 06/Jul/09 05:58 PM

Return to search

Component/s:

SQL

Affects Version/s:

10.4.1.3

Fix Version/s:

10.3.3.1

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
DERBY3037_patch_not_ready_for_commit_v2_diff.txt	2008-01-22 05:28 PM	Mamta A. Satoor	1.0 kB
DERBY3037_patch_not_ready_for_commit_v2_stat.txt	2008-01-22 05:28 PM	Mamta A. Satoor	0.2 kB
Derby_3037_AlterTableConstantActionChanges_v1_diff.txt	2007-12-19 09:25 PM	Mamta A. Satoor	1 kB
Derby_3037_AlterTableConstantActionChanges_v1_stat.txt	2007-12-19 09:25 PM	Mamta A. Satoor	0.2 kB
DERBY_3304_Repro.java	2008-01-22 06:31 PM	Mamta A. Satoor	2 kB

Issue Links:

Reference

This issue relates to:

~~DERBY-827~~ Performance can be improved by re-using language ResultSets across Activation executions.

Urgency:	Normal
Issue & fix info:	Repro attached

Description

« Hide

~~DERBY-827~~ (correctly) changed the lifetime of the language ResultSet tree to be the lifetime of the activation, but did not fix up the correct calls to ResultSet.close() and ResultSet.finish().

A language ResultSet's lifetime should be driven by the activation, so activation.close() should call finish() on its ResultSet.

EmbedResultSet should call close on its language ResultSet (theResults field) when the JDBC ResultSet is closed, it should not be calling finish() on its ResultSet.

See comments in ~~DERBY-827~~ for some more details and issues.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

No work has yet been logged on this issue.