[#DERBY-3037] Language ResultSet.finish() is called even when the ResultSet is going to be re-used.

Derby

Language ResultSet.finish() is called even when the ResultSet is going to be re-used.

Created: 31/Aug/07 11:40 PM Updated: 06/Jul/09 05:58 PM

Return to search

Component/s:

SQL

Affects Version/s:

10.4.1.3

Fix Version/s:

10.3.3.1

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
DERBY3037_patch_not_ready_for_commit_v2_diff.txt	2008-01-22 05:28 PM	Mamta A. Satoor	1.0 kB
DERBY3037_patch_not_ready_for_commit_v2_stat.txt	2008-01-22 05:28 PM	Mamta A. Satoor	0.2 kB
Derby_3037_AlterTableConstantActionChanges_v1_diff.txt	2007-12-19 09:25 PM	Mamta A. Satoor	1 kB
Derby_3037_AlterTableConstantActionChanges_v1_stat.txt	2007-12-19 09:25 PM	Mamta A. Satoor	0.2 kB
DERBY_3304_Repro.java	2008-01-22 06:31 PM	Mamta A. Satoor	2 kB

Issue Links:

Reference

This issue relates to:

~~DERBY-827~~ Performance can be improved by re-using language ResultSets across Activation executions.

Urgency:	Normal
Issue & fix info:	Repro attached

Description

« Hide

~~DERBY-827~~ (correctly) changed the lifetime of the language ResultSet tree to be the lifetime of the activation, but did not fix up the correct calls to ResultSet.close() and ResultSet.finish().

A language ResultSet's lifetime should be driven by the activation, so activation.close() should call finish() on its ResultSet.

EmbedResultSet should call close on its language ResultSet (theResults field) when the JDBC ResultSet is closed, it should not be calling finish() on its ResultSet.

See comments in ~~DERBY-827~~ for some more details and issues.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Daniel John Debrunner made changes - 31/Aug/07 11:41 PM

Field	Original Value	New Value
Link		This issue relates to ~~DERBY-827~~ [ ~~DERBY-827~~ ]

Daniel John Debrunner made changes - 31/Aug/07 11:41 PM

Summary

Language ResultSet.finish() is called eevn when the ResultSet is going to be re-used.

Language ResultSet.finish() is called even when the ResultSet is going to be re-used.

Mamta A. Satoor made changes - 06/Dec/07 07:44 PM

Assignee

Mamta A. Satoor [ mamtas ]

Mamta A. Satoor made changes - 07/Dec/07 07:50 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Fix Version/s		10.4.0.0 [ 12312540 ]
Fix Version/s		10.3.2.2 [ 12312885 ]
Resolution		Fixed [ 1 ]

Daniel John Debrunner made changes - 08/Dec/07 01:26 AM

Status	Resolved [ 5 ]	Reopened [ 4 ]
Resolution	Fixed [ 1 ]

Mamta A. Satoor made changes - 19/Dec/07 09:25 PM

Attachment		Derby_3037_AlterTableConstantActionChanges_v1_stat.txt [ 12371986 ]
Attachment		Derby_3037_AlterTableConstantActionChanges_v1_diff.txt [ 12371985 ]

Mamta A. Satoor made changes - 20/Dec/07 01:14 AM

Derby Info

[Patch Available]

Dyre Tjeldvoll made changes - 04/Jan/08 10:05 AM

Derby Info

[Patch Available]

Mamta A. Satoor made changes - 22/Jan/08 05:28 PM

Attachment		DERBY3037_patch_not_ready_for_commit_v2_stat.txt [ 12373766 ]
Attachment		DERBY3037_patch_not_ready_for_commit_v2_diff.txt [ 12373765 ]

Mamta A. Satoor made changes - 22/Jan/08 06:31 PM

Attachment

DERBY_3304_Repro.java [ 12373771 ]

Andrew McIntyre made changes - 07/May/08 06:12 AM

Fix Version/s	10.3.2.2 [ 12312885 ]
Fix Version/s	10.4.1.3 [ 12313111 ]
Fix Version/s		10.3.3.1 [ 12313143 ]

Rick Hillegas made changes - 06/Jul/09 05:58 PM

Issue & fix info		[Repro attached]
Urgency		Normal