Issue Details (XML | Word | Printable)

Key: DERBY-2720
Type: Improvement Improvement
Status: Reopened Reopened
Priority: Minor Minor
Assignee: Mamta A. Satoor
Reporter: Mike Matrigali
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby

remove dead code associated with unsupported National Char implementation

Created: 29/May/07 05:42 PM   Updated: 07/May/08 06:12 AM
Return to search
Component/s: SQL
Affects Version/s: None
Fix Version/s: 10.3.3.1

Time Tracking:
Not Specified


 Description  « Hide
Derby still has some untested, unused code relating to a non-standard implementation of a Nationa Char type. The current code can be removed.
I believe the interesting functionality associated with this is now provided by DERBY-1478 (territory based collation) . If Derby ever implements a
National Char type it should do so differently than the existing code, collation should not be tied to the National Char type.

I believe a future National char type might have to maintain a separate type id for compatibility with jdbc interface, but actual implmentation should be
the same code as the char types. Collating of the the national char type should be supported in exactly same way as regular char types.

If anyone is really intested in the national char code, it's history will always be available in svn, and a consistent version is available by looking at 10.0, 10.1,
and 10.2 codelines. I would propose any removal of code only take place in trunk and not be backported to a released codeline.



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Repository Revision Date User Message
ASF #612525 Wed Jan 16 17:29:02 UTC 2008 mamta DERBY-2720 and DERBY-3315
Removing the disabled national character related code. This will make it easy to maintain
the territory based code.
Files Changed
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/jdbc/Util.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueFactoryImpl.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TypeCompilerFactoryImpl.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DTSClassInfo.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataValueFactory.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ColumnDefinitionNode.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/BaseTypeCompiler.java
DEL /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLNationalLongvarchar.java
DEL /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLNationalChar.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/compile/TypeCompiler.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/sql/compile/C_NodeTypes.java
DEL /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLNationalVarchar.java
MODIFY /db/derby/code/trunk/java/client/org/apache/derby/client/am/Types.java
DEL /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLNClob.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/catalog/types/TypesImplInstanceGetter.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/Like.java
MODIFY /db/derby/code/trunk/java/client/org/apache/derby/client/am/PreparedStatement.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/LikeEscapeOperatorNode.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/TypeId.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/catalog/types/TypeDescriptorImpl.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/catalog/types/BaseTypeIdImpl.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/types/SQLChar.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CLOBTypeCompiler.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ResultColumn.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/ModifyColumnNode.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/BinaryComparisonOperatorNode.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/services/io/RegisteredFormatIds.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql/compile/CharTypeCompiler.java
MODIFY /db/derby/code/trunk/java/engine/org/apache/derby/iapi/services/io/StoredFormatIds.java

Repository Revision Date User Message
ASF #612576 Wed Jan 16 21:46:54 UTC 2008 mamta Merging changes (revision 612525) from trunk into 10.3 codeline. Had to undo the changes
to TypeDescriptorImpl becase trunk has a method isStringType in TypeDescriptorImpl but
10.3 codeline does not have it. Other than that, the merge from trunk into 10.3 worked
fine. The tests on 10.3 codeline ran fine on Windows XP machine with Sun's jdk14.

The commit comments for trunk were as follows
DERBY-2720 and DERBY-3315
Removing the disabled national character related code. This will make it easy to maintain
the territory based code.
Files Changed
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/TernaryOperatorNode.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/catalog/types/BaseTypeIdImpl.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/CLOBTypeCompiler.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/SQLChar.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/ResultColumn.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/ModifyColumnNode.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/BinaryComparisonOperatorNode.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/CharTypeCompiler.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/services/io/RegisteredFormatIds.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/services/io/StoredFormatIds.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/ColumnDefinitionNode.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/DataValueFactoryImpl.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/jdbc/Util.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/DTSClassInfo.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/DataValueFactory.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/BaseTypeCompiler.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/TypeCompilerFactoryImpl.java
DEL /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/SQLNationalLongvarchar.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/sql/compile/TypeCompiler.java
DEL /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/SQLNationalChar.java
DEL /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/SQLNationalVarchar.java
MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/am/Types.java
DEL /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/SQLNClob.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/sql/compile/C_NodeTypes.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/catalog/types/TypesImplInstanceGetter.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/Like.java
MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/am/PreparedStatement.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/impl/sql/compile/LikeEscapeOperatorNode.java
MODIFY /db/derby/code/branches/10.3/java/engine/org/apache/derby/iapi/types/TypeId.java

Repository Revision Date User Message
ASF #612865 Thu Jan 17 16:52:35 UTC 2008 mamta While working on DERBY-2720, I removed national datatypes as one of the unsupported data
types(revision 612525) and that caused the test failure for SetObjectUnsupportedTest since
we stopped recognizing national dataypes as one of the unsupported datatypes. The fix
required changes in only one class which I had modified incorrectly in revision 612525.
This test failure was not caught earlier by my local runs of the test because I had used
JDK14 which has JDBC3 support and this paritcular test requires JDBC4 support.
Files Changed
MODIFY /db/derby/code/trunk/java/client/org/apache/derby/client/am/PreparedStatement.java

Repository Revision Date User Message
ASF #612872 Thu Jan 17 17:06:58 UTC 2008 mamta Merging changes from trunk(revision 612865) into 10.3 codeline to fix the failure in
SetObjectUnsupportedTest. The commit comments for trunk were as follows

While working on DERBY-2720, I removed national datatypes as one of the unsupported data
types(revision 612525) and that caused the test failure for SetObjectUnsupportedTest since
we stopped recognizing national dataypes as one of the unsupported datatypes. The fix
required changes in only one class which I had modified incorrectly in revision 612525.
This test failure was not caught earlier by my local runs of the test because I had used
JDK14 which has JDBC3 support and this paritcular test requires JDBC4 support.
Files Changed
MODIFY /db/derby/code/branches/10.3/java/client/org/apache/derby/client/am/PreparedStatement.java