Issue Details (XML | Word | Printable)

Key: DERBY-2600
Type: Sub-task Sub-task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: V.Narayanan
Reporter: V.Narayanan
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby
DERBY-208

Remove temporary code added to enable testing of CLOB locator related stored procedures.

Created: 02/May/07 11:52 AM   Updated: 15/Jun/07 12:37 PM
Return to search
Component/s: Network Server
Affects Version/s: None
Fix Version/s: 10.3.1.4

Time Tracking:
Not Specified

File Attachments:
  Size
File Licensed for inclusion in ASF works RemoveTemporaryCode_v1.diff 2007-05-02 12:05 PM V.Narayanan 4 kB
File Licensed for inclusion in ASF works RemoveTemporaryCode_v1.stat 2007-05-02 12:05 PM V.Narayanan 0.3 kB

Resolution Date: 08/May/07 03:33 PM


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
V.Narayanan added a comment - 02/May/07 11:57 AM
While the implementation of Stored procedures related to LOB related JDBC methods was being done temporary code had been added to LOBStoredProcedure.CLOBSETSTRING(corresponding to the CLOBSETSTRING stored procedure) that will insert a clob with data into the hashmap and will allow the testing of the clob related locator stored procedures.

The set methods of Clob have been implemented(https://issues.apache.org/jira/browse/DERBY-2346) and this temporary code can be removed.

V.Narayanan added a comment - 02/May/07 12:05 PM
The temporary code related to CLOBSETSTRING has been removed from the LOBStoredProcedure class. Correspondingly the code in ClobStoredProcedureTest that made use of this temporary code has also been removed.

I have run the ClobStoredProcedureTest and it passes.

I will run junit All and will report back the results.

Please consider this patch for reviews and comments.

V.Narayanan added a comment - 02/May/07 12:11 PM
Running tests on attached patch. Will revert back with test results. Enabling the patch available flag.

Rick Hillegas added a comment - 03/May/07 12:43 PM
Thanks for the patch, Narayanan. Looks non-controversial to me. Tests ran cleanly for me. Committed at subversion revision 534824.

V.Narayanan added a comment - 03/May/07 12:56 PM
Thanks a ton for the commit Rick. Many thanks for the reviews and comments and the final commit for the patch.

Narayanan

V.Narayanan added a comment - 08/May/07 03:33 PM
The final patches to this issue have been submitted and committed. Resolving the issue.

V.Narayanan added a comment - 15/Jun/07 12:37 PM
All patches submitted and committed.