[DERBY-2578] Change CurrentDatetimeOperatorNode to use ExpressionClassBuilder to generate code for DVD rather than going directly though TypeCompiler

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 10.3.1.4
• Fix Version/s: 10.3.1.4
• Component/s: SQL
• Assignee: Mamta A. Satoor
• Reporter: Mamta A. Satoor
• Created: 22/Apr/07 03:38
• Updated: 02/May/13 02:29
• Resolved: 01/May/07 21:47

Description

I am starting to think about the code generation for DERBY-1478 language based ordering. Depending on the collation type of the DTD, we might want to generate CollatorSQLChar rather than SQLChar for instance. In order to centralize this code, I am changing CurrentDatetimeOperatorNode's generateExpression so that it goes through ExpressionClassBuilder.generateDataValue rather than doing TypeCompiler.generateDataValue. This way, hopefully, I will only have to change ExpressionClassBuilder.generateDataValue to take care of the collation dependency of DVD generation. All the other classes which need to generate a DVD already go through ExpressionClassBuilder.generateDataValue. Will commit the patch for this soon. The tests have passed with no new failures.

Issue Links

• is depended upon by: DERBY-2335 Compare character datatypes with different collation ordering.