Change CurrentDatetimeOperatorNode to use ExpressionClassBuilder to generate code for DVD rather than going directly though TypeCompiler

• Key: DERBY-2578
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Mamta A. Satoor
• Reporter: Mamta A. Satoor
• Component/s: SQL
• Affects Version/s: 10.3.1.4
• Fix Version/s: 10.3.1.4

Description

I am starting to think about the code generation for DERBY-1478 language based ordering. Depending on the collation type of the DTD, we might want to generate CollatorSQLChar rather than SQLChar for instance. In order to centralize this code, I am changing CurrentDatetimeOperatorNode's generateExpression so that it goes through ExpressionClassBuilder.generateDataValue rather than doing TypeCompiler.generateDataValue. This way, hopefully, I will only have to change ExpressionClassBuilder.generateDataValue to take care of the collation dependency of DVD generation. All the other classes which need to generate a DVD already go through ExpressionClassBuilder.generateDataValue. Will commit the patch for this soon. The tests have passed with no new failures.

Comments

[Mamta A. Satoor]

Attaching patch to address this Jira entry. Will commit in next few minutes. No new failures caused by the patch.

[Mamta A. Satoor]

Commited the patch with revision 531138. If any comments, feel free to share.