[#DERBY-2226] Move column bitset computation to IndexToBaseRowNode

Derby

Move column bitset computation to IndexToBaseRowNode

Created: 10/Jan/07 11:07 AM Updated: 29/Jun/09 02:18 PM

Return to search

Component/s:

SQL

Affects Version/s:

None

Fix Version/s:

10.3.1.4

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
derby-2226.v1.diff	2007-01-10 12:52 PM	Dyre Tjeldvoll	9 kB
derby-2226.v1.stat	2007-01-10 12:52 PM	Dyre Tjeldvoll	0.5 kB
derby-2226.v2.diff	2007-01-15 11:36 AM	Dyre Tjeldvoll	10 kB
derby-2226.v2.stat	2007-01-15 11:36 AM	Dyre Tjeldvoll	0.6 kB

Bug behavior facts:	Performance
Resolution Date:	16/Jan/07 09:59 AM

Description

« Hide

The constructor for IndexRowToBaseRowResultSet
takes a bitset describing the columns coming from the heap and a
bitset describing the columns coming from the index. But in every
IndexRowToBaseRowResultSet one also has to compute _all_ referenced
columns (union of heap and index bitsets), and frequently also those
columns _only_ coming from the heap (set difference between heap and
index).

But the value of these "set products" seem _only_ to depend on objects
that are fixed at compile time (in IndexToBaseRowNode), so it would be
cleaner (and possibly more efficient) to compute these products there.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Dyre Tjeldvoll added a comment - 10/Jan/07 12:54 PM

I have attached a patch derby-2226.v1 for this issue.
Derbyall and Junit tests pass.

Please review.

[ Permlink | « Hide ]

Dyre Tjeldvoll added a comment - 15/Jan/07 11:37 AM

I have attached derby-2226.v2 which addresses the review comments.

[ Permlink | « Hide ]

Knut Anders Hatlen added a comment - 16/Jan/07 09:59 AM

Thank you for addressing my comments, Dyre. Patch v2 looks good. Committed revision 496645.