Issue Details (XML | Word | Printable)

Key: DERBY-2145
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Trivial Trivial
Assignee: Bernt M. Johnsen
Reporter: Bernt M. Johnsen
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Derby

Remove LIKE tweak from metadata.properties

Created: 05/Dec/06 10:11 AM   Updated: 29/Jun/09 01:13 PM
Return to search
Component/s: SQL
Affects Version/s: None
Fix Version/s: 10.4.1.3

Time Tracking:
Not Specified

File Attachments:
  Size
File Licensed for inclusion in ASF works d2145-part-2.diff 2007-06-29 12:58 PM Bernt M. Johnsen 1 kB
File Licensed for inclusion in ASF works d2145-part-2.stat 2007-06-29 12:51 PM Bernt M. Johnsen 0.1 kB
File Licensed for inclusion in ASF works d2145-part-3.diff 2007-06-29 01:10 PM Bernt M. Johnsen 0.6 kB
File Licensed for inclusion in ASF works d2145.diff 2007-06-19 01:23 PM Thomas Nielsen 0.6 kB
File Licensed for inclusion in ASF works d2145.stat 2007-06-19 01:23 PM Thomas Nielsen 0.1 kB
Issue Links:
Blocker
 
Reference
 

Resolution Date: 29/Jun/07 01:11 PM


 Description  « Hide
The tweak in the second last line in metadata.properties:
      AND (V."COLUMN_NAME" LIKE ? OR V."COLUMN_NAME" = ?) \
may be changed to
      AND V."COLUMN_NAME" LIKE ? \
when DERBY-1231 is fixed


 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Bernt M. Johnsen added a comment - 05/Dec/06 10:13 AM
A fix for this issue should not be back-ported to the 10.2 branch. Se Kunt's komment in DERBY-1231

Andrew McIntyre added a comment - 25/Jan/07 08:38 PM
Unsetting Fix Version on unassigned issues.

Thomas Nielsen added a comment - 19/Jun/07 01:23 PM - edited
Attached Bernts proposed diff for this issue now that DERBY-1231 is fixed.
suites.All pass.

Bernt M. Johnsen added a comment - 27/Jun/07 11:33 AM
Committed revision 551124.

Ole Solberg added a comment - 29/Jun/07 08:51 AM
Checkin 551124 appears to have caused testGetFunctionColumnsStartingWithDUMMY(org.apache.derbyTesting.functionTests.tests.jdbc4.TestDbMetaData)java.sql.SQLException: The parameter position '4' is out of range. The number of parameters for this prepared statement is '3'.

See DERBY-2880.

Bernt M. Johnsen added a comment - 29/Jun/07 10:18 AM
This slipped thorugh because the test suite was not run in JDK 1.6. I have a patch ready, just waiting for the test suite.

Bernt M. Johnsen added a comment - 29/Jun/07 12:51 PM
Attached a patch which fixes the bug Ole found.

Bernt M. Johnsen added a comment - 29/Jun/07 12:55 PM
So... the correct diff.

Bernt M. Johnsen added a comment - 29/Jun/07 12:56 PM
with Grant license....

Bernt M. Johnsen added a comment - 29/Jun/07 12:58 PM
The correct diff with grant license. The sad thing is that when I start doing these mistakes, it's broadcast all over the world (at least all over the community) and archived for the future. Anyway, suites.All runs without errors on JDK 1.6. Will commit.

Bernt M. Johnsen added a comment - 29/Jun/07 01:01 PM
Committed revision 551878.

Bernt M. Johnsen added a comment - 29/Jun/07 01:10 PM
Patch to remove the no more needed PreparedStatement in EmbedDatabaseMetaData.getFunctionColumns()

Bernt M. Johnsen added a comment - 29/Jun/07 01:11 PM
Committed revision 551882.