|
[
Permlink
| « Hide
]
Andrew McIntyre added a comment - 02/Nov/06 05:53 AM
Attaching simple patch to take care of this issue. Need to also investigate whether we should show other table types if no schema is provided.
Hi Andrew, I applied the patch and it seems to work fine for me. I can see the behavior changes and they are as I expected. I think the new behavior is reasonable.
Are there no tests for this feature in our test suite? I was a little bit surprised that there were no test changes in this patch. Thanks for the review Bryan, I was just capturing the little patch that I posted for Oystein on the list in this JIRA.
Attaching a complete patch that updates ij7.sql to include a testcase for this issue. I'll commit this shortly if there are no further comments. Just a note, in the future, it might be nice to have the syntax: SHOW [ SYSTEM ] TABLES and then take the system tables out of the results returned by default for SHOW TABLES, but that enhancement should be handled in a different JIRA. Hi Andrew, the new patch looks great to me. I was able to run the new test both with and without your code change and got the expected results. +1 to your patch, and +1 to your idea about an alternate syntax to let the user control the system table behavior, too.
Committed to trunk with revision 474628 and 10.2 with revision 474630.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||