[#DBUTILS-52] QueryRunner is not thread-safe

Commons DbUtils

QueryRunner is not thread-safe

Created: 11/Mar/09 04:54 PM Updated: 15/Mar/09 07:05 PM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

1.2

Time Tracking:

Not Specified

Resolution Date:

15/Mar/09 07:05 PM

Description

« Hide

sebb pointed out: "QueryRunner Javadoc says the class is thread-safe. However it has a protected mutable variable DataSource which can also be set/got via public methods. If one thread sets the variable, another may not see the correct value, so the class is not thread-safe."

We should make the DataSource final and remove the setter.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#752523	Wed Mar 11 16:55:49 UTC 2009	dfabulich	~~DBUTILS-52~~, removing setDataSource method and making DataSource final
				Files Changed
				MODIFY /commons/proper/dbutils/trunk/src/java/org/apache/commons/dbutils/QueryRunner.java

Dan Fabulich made changes - 11/Mar/09 04:57 PM

Field	Original Value	New Value
Assignee		Dan Fabulich [ dfabulich ]

Repository	Revision	Date	User	Message
ASF	#754722	Sun Mar 15 19:00:48 UTC 2009	dfabulich	Noting ~~DBUTILS-52~~
				Files Changed
				MODIFY /commons/proper/dbutils/trunk/xdocs/changes.xml

[ Permlink | « Hide ]

Dan Fabulich added a comment - 15/Mar/09 07:05 PM

Fixed in revision 752523.

Dan Fabulich made changes - 15/Mar/09 07:05 PM

Resolution		Fixed [ 1 ]
Fix Version/s		1.2 [ 12312139 ]
Status	Open [ 1 ]	Closed [ 6 ]