Issue Details (XML | Word | Printable)

Key: DBUTILS-52
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Dan Fabulich
Reporter: Dan Fabulich
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Commons DbUtils

QueryRunner is not thread-safe

Created: 11/Mar/09 04:54 PM   Updated: 15/Mar/09 07:05 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 1.2

Time Tracking:
Not Specified

Resolution Date: 15/Mar/09 07:05 PM


 Description  « Hide
sebb pointed out: "QueryRunner Javadoc says the class is thread-safe. However it has a protected mutable variable DataSource which can also be set/got via public methods. If one thread sets the variable, another may not see the correct value, so the class is not thread-safe."

We should make the DataSource final and remove the setter.



 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Dan Fabulich added a comment - 15/Mar/09 07:05 PM
Fixed in revision 752523.