[dbutils] BeanListHandler and BeanHandler fail to support java.sql.Date()

• Key: DBUTILS-1
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Xinyi-Huang(???)
• Fix Version/s: 1.1

Environment

Operating System: Windows 2000
Platform: PC

Description

BeanListHandler or BeanHandler fail to support the java.sql.Date type when
read from database.
I just add some codes to callSetter the method callSetter of BeanProcessor as
----------------------
else if(params[0].getName().equals("java.sql.Date")){
value = (value==null)?null:new java.sql.Date
(((java.util.Date)value).getTime());
setter.invoke(target, new Object[] {value});
----------------------


org.apache.commons.dbutils.BeanProcessor

private void callSetter(Object target, PropertyDescriptor prop, Object value)
throws SQLException {

Method setter = prop.getWriteMethod();

if (setter == null) { return; }

Class[] params = setter.getParameterTypes();
try {
// Don't call setter if the value object isn't the right type
if (this.isCompatibleType(value, params[0])) {
setter.invoke(target, new Object[] { value });
}else if(params[0].getName().equals("java.sql.Date")){
value = (value==null)?null:new java.sql.Date
(((java.util.Date)value).getTime());
setter.invoke(target, new Object[] {value});
}

} catch (IllegalArgumentException e) { throw new SQLException( "Cannot set " + prop.getName() + ": " + e.getMessage()); } catch (IllegalAccessException e) { throw new SQLException( "Cannot set " + prop.getName() + ": " + e.getMessage()); } catch (InvocationTargetException e) { throw new SQLException( "Cannot set " + prop.getName() + ": " + e.getMessage()); }
}

Comments

[Alan B. Canon]

This patch also addresses DBUTILS-3. It may not work if the patch recently attached to that issue has already been applied to source.

[Henri Yandell]

I think it needs a bit more work to support java.sql.Time and Timestamp, and I think the code can be expressed a bit differently to keep things clear.

Alan, how does the 'Proposed-DBUTILS-1.patch' that I just uploaded look to you?

[Alan B. Canon]

Agree with Proposed-DBUTILS-1.patch. Much nicer. Apply?

svn ci -m "Enabling the bean handlers to support java.sql.Date, Time and Timestamp. #DBUTILS-1. "

Sending src/java/org/apache/commons/dbutils/BeanProcessor.java
Transmitting file data .
Committed revision 470904.