[DBCP-503] org.apache.commons.dbcp2.datasources.InstanceKeyDataSourceFactory.closeAll() does not close all

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.4.0
• Assignee: Gary D. Gregory
• Reporter: Gary D. Gregory
• Created: 11/Jun/18 14:10
• Updated: 11/Jun/18 20:35
• Resolved: 11/Jun/18 15:06

Description

org.apache.commons.dbcp2.datasources.InstanceKeyDataSourceFactory.closeAll() does not close all if an exception is thrown while closing one of the resources.

    /**
     * Closes all pools associated with this class.
     *
     * @throws Exception
     *             a {@link ListException} containing all exceptions thrown by {@link InstanceKeyDataSource#close()}
     * @see InstanceKeyDataSource#close()
     * @see ListException
     * @since 2.4.0 throws a {@link ListException} instead of, in 2.3.0 and before, the first exception thrown by
     *        {@link InstanceKeyDataSource#close()}.
     */