[DBCP-404] Mutable fields should be private

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 31/Oct/13 20:11
• Updated: 31/May/14 04:07
• Resolved: 02/Feb/14 20:38

Description

Non-private mutable fields make thread-safety harder.

Make all mutable fields private (or at worst package-protected), and use getters/setters for access if necessary.

This allows synchronisation to be easily added later if necessary, as well as potentially allowing validation of values.