Uploaded image for project: 'Commons DBCP'
  1. Commons DBCP
  2. DBCP-384

PoolingDriver.accessToUnderlyingConnectionAllowed is thread-hostile

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0
    • None

    Description

      The field PoolingDriver.accessToUnderlyingConnectionAllowed is static but mutable; this is inherently thread-hostile.

      It seems completely unnecessary for the field to be static; surely it could be an instance variable?
      Better yet, drop the setter/getter and make the field final, set by the ctor.

      Attachments

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            sebb Sebb
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment