[DBCP-333] Unable to create a JDBC driver using custom class loader

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3, 1.4
• Fix Version/s: 1.3.1, 1.4.1
• Assignee: Mark Thomas
• Reporter: Krasimir Nedkov
• Created: 04/May/10 12:08
• Updated: 24/Feb/15 03:23
• Resolved: 22/Mar/11 20:46

Description

Hello,

I'm unable to instantiate my JDBC driver using a custom class loader:
BasicDataSource ds = new BasicDataSource();
String connectURL = "jdbc:mysql://"config.getHost()"/"+config.getDatabaseName();
ds.setDriverClassName(MySQLStore.MYSQL_DRIVER);
ds.setDriverClassLoader(config.getClass().getClassLoader());
.....

Having a look at the org.apache.commons.dbcp.BasicDataSource.createConnectionFactory() method implementation, I found that the class loader is actually ignored. In the first part of the method there is an attempt to load the class that seems to pass successfully, but the loaded class is not assigned to the driverFromCCL variable:
if (driverClassLoader == null)

{ Class.forName(driverClassName); }

else

{ Class.forName(driverClassName, true, driverClassLoader); }

Then in the second part of the method driverFromCCL is still null and instead of instantiating the driver directly, DriverManager.getDriver(url) is called, which fails:
if (driverFromCCL == null)

{ driver = DriverManager.getDriver(url); }

else {
// Usage of DriverManager is not possible, as it does not
// respect the ContextClassLoader
driver = (Driver) driverFromCCL.newInstance();
if (!driver.acceptsURL(url))

{ throw new SQLException("No suitable driver", "08001"); }

}

Kind regards,
Krasimir

Issue Links

• is blocked by: DBCP-203 Want to provide a ClassLoader for BasicDataSource to use for loading a JDBC driver.