[DBCP-322] CPDSConnectionFactory.validateObject(Object) ignores Throwable

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2, 1.2.1, 1.2.2, 1.3, 1.4
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: Sebb
• Created: 22/Jan/10 12:32
• Updated: 31/May/14 04:14
• Resolved: 26/Apr/12 16:33

Description

CPDSConnectionFactory.validateObject(Object) catches and ignores Throwable, which is a bit excessive. For example:

if (rset != null) {
    try {
        rset.close();
    } catch (Throwable t) {
        // ignore
    }
}

close() can only throw SQLException, and that is all that should be ignored. In particular, ThreadDeath should never be ignored.

Same applies to KeyedCPDSConnectionFactory.

Basic[Managed]Datasource also catch Throwable, but rethrow it as SQLNestedException.
This is a bit better, but there's still the problem with ThreadDeath.