[DBCP-271] Thread safety issues in AbandonedTrace class

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3
• Assignee: Unassigned
• Reporter: Sebb
• Created: 27/Jun/08 09:59
• Updated: 15/Feb/10 02:35
• Resolved: 25/Jan/09 02:52

Description

DBCP-270 implies that the AbandonedTrace class is called from multiple threads, however it is not thread-safe:

• SimpleDateFormat is not threadsafe, but it is called without protection.
• various instance fields need to be made final to ensure that they are published correctly (memory visibility)
• getLastUsed/setLastUsed need to be synchronized - or better, createdBy made volatile so printStackTrace can access the variable safely
  (createdBy is rewritten, not updated, so lost updates are not important)

Also, the Javadoc for printStackTrace() is wrong.