NPE in case of an SQLException to be thrown on checkOpen() in DelegatingConnection

• Key: DBCP-241
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Jörg Heinicke
• Affects Version/s: 1.2.2
• Fix Version/s: 1.3

Description

I only got it from the Spring forums (http://forum.springframework.org/showthread.php?t=44068). I have no idea which version or if it is already fixed. It should be easy to review.

Stacktrace:

java.lang.NullPointerException
at org.apache.commons.dbcp.PoolingConnection.toString(PoolingConnection.java:248)
at java.lang.String.valueOf(String.java:2615)
at java.lang.StringBuffer.append(StringBuffer.java:220)
at org.apache.commons.dbcp.DelegatingConnection.checkOpen(DelegatingConnection.java:354)
at org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:246)
at org.apache.commons.dbcp.PoolingDataSource$PoolGuardConnectionWrapper.prepareStatement(PoolingDataSource.java:302)
at org.hibernate.jdbc.AbstractBatcher.getPreparedStatement(AbstractBatcher.java:505)
at org.hibernate.jdbc.AbstractBatcher.getPreparedStatement(AbstractBatcher.java:423)
at org.hibernate.jdbc.AbstractBatcher.prepareQueryStatement(AbstractBatcher.java:139)

implementation of the method:

protected void checkOpen() throws SQLException {
if(_closed) { throw new SQLException ("Connection " + _conn + " is closed."); }
}

Regards

Joerg