The BasicDataSource setLoginTimeout and getLoginTimeout are not supported

• Key: DBCP-238
• Type: Bug
• Status: Resolved
• Resolution: Won't Fix
• Priority: Major
• Assignee: Unassigned
• Reporter: Benoit Lafontaine
• Affects Version/s: 1.2.2
• Fix Version/s: 1.3

Description

Methods setLoginTimeout() and getLoginTimeout() are not supported.

Comments

[Benoit Lafontaine]

The DBCP-218 is fixed by adding a Javadoc comment.

[Benoit Lafontaine]

This patch try to add the loginTimeout feature.
This is made by creating another thread that will call the _driver.connect(_connectUri, _props);
The main thread will wait for it by using the Thread.join(timeout) method.
If the join method returns by timeout and the connect didn't finished, then the main method will throw an SQLException "timeout".

Anyway, for the moment, the second Thread will not be stopped, even if the Thread.interrupted() method is called.

[Phil Steitz]

I see four alternatives here. If others have better ideas, please chime in.

1) Apply cleaned up version of the patch.
2) Add a loginTimeout property to BDS, DCF and pass it to the driver as a property.
3) View this as synonymous with maxWait (modulo unit difference)
4) WONTFIX

I don't like the idea of spawning a thread in 1), 2) can already be accomplished in the connect string, 3) is redundant, so unless someone has a better idea, I think we should close as WONTFIX.

[Mark Thomas]

I agree with Phil's analysis. Therefore, resolving as WONTFIX.