InstanceKeyDataSource.getConnection, exception during setup Defaults()

• Key: DBCP-237
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Oliver Matz
• Affects Version/s: 1.2.1, 1.2.2
• Fix Version/s: 1.3

Description

Problem in
org.apache.commons.dbcp.datasources.InstanceKeyDataSource.getConnection(String username, String password)
if setupDefaults() throws an Exception, the connection will not get closed.
After a while, this will cause the following exception:
org.apache.commons.dbcp.SQLNestedException: Could not retrieve connection info from pool

This scenario can happen for Sybase jConnect2 5.5. The exception that may be thrown by jConnect2 is:
com.sybase.jdbc2.jdbc.SybConnectionDeadException: JZ0C0: Connection is already closed.

More details:
The last lines of the method are as follows:
-------
Connection con = info.getPooledConnection().getConnection();
setupDefaults(con, username);
con.clearWarnings();
return con;
-------

In my case, the exception happens in the second line of this snippet,
so no code gets the chance close con and release the resources.

I propose to change it to:

-------
Connection con = info.getPooledConnection().getConnection();
try
{
setupDefaults(con, username);
con.clearWarnings();
return con;
}
catch (Exception exc)
{
try

{ con.close(); }

catch (Exception exc)

{ getLogWriter().println("ignoring exception during close: " + exc); // uncertain here. }

throw exc;
}