[#DBCP-233] Allow connection, statement, and result set to be closed multiple times

Commons Dbcp

Allow connection, statement, and result set to be closed multiple times

Created: 17/Jul/07 04:17 AM Updated: 16/Mar/09 09:19 PM

Return to search

Component/s:

None

Affects Version/s:

None

Fix Version/s:

1.3

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	CloseTwice.patch	2007-07-17 04:18 AM	Dain Sundstrom	13 kB

Resolution Date:

16/Mar/09 09:19 PM

Description

« Hide

This patch allows Connection, Statement, PreparedStatement, CallableStatement and ResultSet to be closed multiple times. The first time close is called the resource is closed and any subsequent calls have no effect. This behavior is required as per the JavaDocs for these classes. The patch adds tests for closing all types multiple times and updates any tests that incorrectly assert that a resource can be closed more then once.

This patch fixes ~~DBCP-134~~ and ~~DBCP-3~~

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Repository	Revision	Date	User	Message
ASF	#557176	Wed Jul 18 06:46:16 UTC 2007	psteitz	Changed behavior to allow Connection, Statement, PreparedStatement, CallableStatement and ResultSet to be closed multiple times. The first time close is called the resource is closed and any subsequent calls have no effect. This behavior is required as per the JavaDocs for these classes. Also added tests for closing all types multiple times and updated any tests that incorrectly assert that a resource can not be closed more then once. JIRA: ~~DBCP-233~~ Patch provided by Dain Sundstrom Fixes ~~DBCP-134~~, ~~DBCP-3~~
				Files Changed
				MODIFY /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/cpdsadapter/ConnectionImpl.java MODIFY /jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterResultSet.java MODIFY /jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestManual.java MODIFY /jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/managed/TestManagedDataSource.java MODIFY /jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TesterStatement.java MODIFY /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDriver.java MODIFY /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/DelegatingConnection.java MODIFY /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolablePreparedStatement.java MODIFY /jakarta/commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolingDataSource.java MODIFY /jakarta/commons/proper/dbcp/trunk/xdocs/changes.xml MODIFY /jakarta/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp/TestConnectionPool.java