[#DBCP-216] Improvement of error recovery in KeyedCPDSConnectionFactory

Commons Dbcp

Improvement of error recovery in KeyedCPDSConnectionFactory

Created: 13/Apr/07 02:54 PM Updated: 12/Sep/09 09:23 PM

Return to search

Component/s:

None

Affects Version/s:

1.2.2

Fix Version/s:

1.3

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	KeyedCPDSConnectionFactory.java.diff	2007-04-13 02:55 PM	Marcos Sanz	2 kB

Environment:

Windows XP, Java 1.5.0_06-b05, Sybase ASE 12.5.4, jConnect 6.0.5 EBF 13862, Commons Pool 1.3

Resolution Date:

12/Sep/09 09:23 PM

Description

« Hide

Attached you'll find a patch that improves the recovery of the class in different error situations.

1. The addition of removeConnectionEventListener() in destroyObject() ensures that the listener is removed, which is not guaranteed to have happened upon call of destroyObject(). We are for sure not interested any more in events, since we are about to destroy.

2. The same addition is made to connectionClosed(). Additionally, we have substituted there the call to destroyObject() with a call to pool.invalidateObject(). This is necessary because otherwise the object is destroyed but not removed from the pool.

3. The same substitution is made in connectionErrorOccurred(), otherwise the object might remain in the pool.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Marcos Sanz made changes - 13/Apr/07 02:55 PM

Field	Original Value	New Value
Attachment		KeyedCPDSConnectionFactory.java.diff [ 12355510 ]

Henri Yandell made changes - 03/May/07 07:32 PM

Fix Version/s

1.3 [ 12311977 ]

Phil Steitz made changes - 16/Aug/09 04:15 PM

Assignee

Phil Steitz [ psteitz ]

Phil Steitz made changes - 12/Sep/09 09:23 PM

Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]