Basic datasource should respect the context classloader

• Key: DBCP-214
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Unassigned
• Reporter: Bernd Kolb
• Affects Version/s: 1.2.2
• Fix Version/s: 1.3

Description

I tried to use DBCP in an OSGi environment. This this not possible at the moment, as OSGi uses different classloaders and DBCP does not respect this.
The easiest way to solve this problem would be to use the contextclassloader in case of a ClassNotFoundException

Comments

[Phil Steitz]

Patches welcome

[Bernd Kolb]

Version: 1.2.2
Class: org.apache.commons.dbcp.BasicDataSouce
Method: protected synchronized DataSource createDataSource() (changes made between //### START CHANGE ### and //### END CHANGE ###

Changed code:
//### START CHANGE ###
Class driverFromCCL = null;
if (driverClassName != null) {
try {
try { Class.forName(driverClassName); }catch (ClassNotFoundException e) { driverFromCCL = Thread.currentThread().getContextClassLoader().loadClass(driverClassName); }

} catch (Throwable t) { String message = "Cannot load JDBC driver class '" + driverClassName + "'"; logWriter.println(message); t.printStackTrace(logWriter); throw new SQLNestedException(message, t); }
}

// Create a JDBC driver instance
Driver driver = null;
try {
if (driverFromCCL!= null) {
// Usage of drivermanager is not possible, as it does not respect the ContextClassLoader
driver = (Driver) driverFromCCL.newInstance();
if (!driver.acceptsURL(url)) { new SQLException("No suitable driver", "08001"); }
}else { driver = DriverManager.getDriver(url); }
//### END CHANGE ###

If you need more information, please let me know

Cheers,

Bernd

[Bernd Kolb]

Any updates on that?

Thanks

Bernd

[Mark Thomas]

Thanks for the patch. Sorry it it has been a while. Your patch has been applied.