[CURATOR-451] Background retry may fall into infinite loop

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 4.0.0
• Component/s: Framework
• Assignee: Unassigned
• Reporter: Yongle Zhang
• Created: 06/Feb/18 01:17
• Updated: 06/Feb/18 15:01

Description

Similar to Curator-209, addFailedOperation() function in FailedOperationManager.java could fall into infinite loop when there's network disruption. 

Root cause: when there's an Exception (any type), function addFailedOperation() simply recursively calls itself. And in every recursion, it prints a log.  

 

void addFailedOperation(T details)
{
  ...
  if ( client.getState() == CuratorFrameworkState.STARTED )
  {
    log.debug("Details being added to guaranteed operation set: " + details);
    try
    {
      executeGuaranteedOperationInBackground(details);
    }
    catch ( Exception e )
    {
      ThreadUtils.checkInterrupted(e);
      addFailedOperation(details);
    }
  }
}