[CSV-203] withNullString value is printed without quotes when QuoteMode.ALL is specified; add QuoteMode.ALL_NON_NULL

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3, 1.4
• Fix Version/s: 1.5
• Component/s: Printer
• Labels: regression
• Assignee: Unassigned
• Reporter: Richard Wheeldon
• Created: 22/Nov/16 15:48
• Updated: 03/Sep/17 05:51
• Resolved: 27/Mar/17 19:04

Description

When setting QuoteMode.ALL is set we expect all values to be quoted, even those set as a default. This works in Commons 1.2 but doesn't in 1.4.

Consider the following program:

import org.apache.commons.csv.QuoteMode;
import org.apache.commons.csv.CSVFormat;
import org.apache.commons.csv.CSVPrinter;

public class CommonsCsvIsSlightlyBroken {
    
    public static void main(String[] args) throws Exception {
        CSVFormat format = CSVFormat.EXCEL
            .withNullString("N/A")
            .withIgnoreSurroundingSpaces(true)
            .withQuoteMode(QuoteMode.ALL);
        CSVPrinter printer = new CSVPrinter(System.out, format);
        printer.printRecord(new Object[] { null, "Hello", null, "World" });
    }
}

For 1.2 we get quoted output:

richard@kichemaru:~/$ java -cp ~/.m2/repository/org/apache/commons/commons-csv/1.2/commons-csv-1.2.jar:. CommonsCsvIsSlightlyBroken
"N/A","Hello","N/A","World"

When run with 1.4 we get unquoted output for default fields:

richard@kichemaru:~/$ java -cp ~/.m2/repository/org/apache/commons/commons-csv/1.4/commons-csv-1.4.jar:. CommonsCsvIsSlightlyBroken
N/A,"Hello",N/A,"World"

Issue Links

• is related to: CSV-207 Provide a CSV Format for printing PostgreSQL CSV and Text formats
• relates to: CSV-93 Allow the handling of NULL values