[CONFIGURATION-540] SystemConfiguration copies System.getProperties() instead of directly using it since 1.8

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.8, 1.9
• Fix Version/s: 2.0
• Assignee: Unassigned
• Reporter: subes
• Created: 11/Apr/13 10:43
• Updated: 24/Mar/16 20:20
• Resolved: 13/Apr/13 14:46

Description

In commons-configuration-1.7 the SystemConfiguration directly used the Map of System.getProperties(). Thus when changing the properties inside the SystemConfiguration, the changes were visible in the Map of System.getProperties().

Since commons-configuration-1.8 the SystemConfiguration creates a new Map as a copy of System.getProperties() and thus changes in the SystemConfiguration Map are not visible in the System.getProperties() Map.

In 1.7 this super constructor is used by SystemProperties:

public MapConfiguration(Map map) {
    this.map = map;
}

In 1.9 this super constructor is used by SystemProperties:

public MapConfiguration(Properties props) {
    map = convertPropertiesToMap(props);
}

A fix could look like this:

public SystemConfiguration() {
    super((Map)System.getProperties());
}

This breaks the functionality I expected to be able to use SystemConfiguration as a replacement API for accessing and manipulating SystemProperties. For me this is a regression.

My workaround is currently not to use:

new SystemConfiguration();

but instead use:

new MapConfiguration((Map) System.getProperties());

Issue Links

• duplicates: CONFIGURATION-581 SystemConfiguration can not get the correct system property