[#CONFIGURATION-349] XMLConfigurationProvider cannot create a class that extends XMLConfiguration

Commons Configuration

XMLConfigurationProvider cannot create a class that extends XMLConfiguration

Created: 10/Nov/08 08:27 AM Updated: 22/Aug/09 07:36 PM

Return to search

Component/s:

None

Affects Version/s:

1.5

Fix Version/s:

1.6

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	extended.txt	2008-11-10 08:29 AM	Ralph Goers	4 kB

Resolution Date:

11/Nov/08 09:25 PM

Description

« Hide

XMLConfigurationProvider in DefaultConfigurationBuilder has default scope. When configuring a new ConfigurationProvider to use a class that extends XMLConfiguration an Exception is raised because the setConfigurationClass method cannot be called from the bean utility classes.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Ralph Goers added a comment - 10/Nov/08 08:29 AM

The attached patch provides a unit test for the problem as well as the fix.

Ralph Goers made changes - 10/Nov/08 08:29 AM

Field	Original Value	New Value
Attachment		extended.txt [ 12393620 ]

Oliver Heger made changes - 10/Nov/08 09:33 PM

Assignee

Oliver Heger [ oliver.heger@t-online.de ]

Repository	Revision	Date	User	Message
ASF	#713166	Tue Nov 11 21:02:37 UTC 2008	oheger	~~CONFIGURATION-349~~: Changed visibility of DefaultConfigurationBuilder.XMLConfigurationProvider from package local to public to allow for better extensibility. Thanks to Ralph Goers for the patch.
				Files Changed
				ADD /commons/proper/configuration/trunk/conf/testExtendedXMLConfigurationProvider.xml MODIFY /commons/proper/configuration/trunk/xdocs/changes.xml MODIFY /commons/proper/configuration/trunk/src/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java MODIFY /commons/proper/configuration/trunk/src/test/org/apache/commons/configuration/TestDefaultConfigurationBuilder.java

[ Permlink | « Hide ]

Oliver Heger added a comment - 11/Nov/08 09:25 PM

Patch applied in revision 713166. Many thanks.

Note: I was unable to port this patch to the configuration2 branch because the new type converters cannot deal with conversions to Class objects. We will have to port this later if necessary.

Oliver Heger made changes - 11/Nov/08 09:25 PM

Fix Version/s		1.6 [ 12312450 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Ralph Goers added a comment - 11/Nov/08 10:08 PM

Thanks. I will take a look at what to do on the configuration2 branch.

[ Permlink | « Hide ]

Oliver Heger added a comment - 12/Nov/08 08:54 PM

In this branch the dependency to commons-beanutils was dropped and replaced by an own converter framework (in the converter package). Obviously these converters are not yet as powerful as the ones of beanutils were. In this special case a converter for Class objects is missing.

But maybe we should create a new ticket for this issue.

Oliver Heger made changes - 22/Aug/09 07:36 PM

Status

Resolved [ 5 ]

Closed [ 6 ]