PropertiesConfiguration should allow variable interpolation for includes

• Key: CONFIGURATION-338
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Oliver Heger
• Reporter: David Donn
• Affects Version/s: 1.5
• Fix Version/s: 1.6

Description

It would be nice if Include files were subject to the same variable interpolation as regular properties.

e.g. it should be possible to do
include=${sys:myfilename}

I think it is simply a matter of changing the call in to loadIncludeFile() PropertiesConfiguration.propertyLoaded() from:

loadIncludeFile(files[i].trim());

to:

loadIncludeFile(interpolate(files[i].trim()));

I am happy to submit a patch.

Comments

[Oliver Heger]

Many thanks!

A patch would be appreciated. Any chance you could also provide a unit test?

I have attached my patch. It includes a test. Please let me know if there are any problems and I will fix as this feature it quite important for me so I am keen to get it included.

[Oliver Heger]

Patch applied in revision r703248. Many thanks!

(Leaving open until the patch is also applied to the configuration2 branch.)

[Oliver Heger]

The patch was also ported to the configuration2 branch.