Missing factory method in XMLBeanDeclaration.getNestedBeanDeclarations

• Key: CONFIGURATION-331
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Oliver Heger
• Reporter: Frank Haefemeier
• Affects Version/s: 1.5
• Fix Version/s: 1.6

Description

I create a new BeanDeclaration class on base of XMLBeanDeclaration to extend the behaviour to fill up bean properties with pure XML text nodes. But the problem was, that the method getNestedBeanDeclaration create for all nested child new XMLBeanDeclarations and there
is no way to get my own class. I have to implement the whole method getNestedBeanDeclaration as a copy from the parent class.

Comments

[Oliver Heger]

So you propose a method like

/**
 * Creates a nested <code>BeanDeclaration</code> for a child node of the current configuration node.
 * @param node the affected child node
 * @return the <code>BeanDeclaration</code> for this child node
 */
protected BeanDeclaration(ConfigurationNode node);

in XMLBeanDeclaration. This seems reasonable to me. Are you fine with this method signature?

[Frank Haefemeier]

IMHO more convenient for the method would be

/**
 * Creates a nested <code>BeanDeclaration</code> for a child node of the current configuration node.
 * @param node the affected child node
 * @return the <code>BeanDeclaration</code> for this child node
 */
protected BeanDeclaration createBeanDeclaration(ConfigurationNode node);

I think, this is what you thought as you wrote it, right? Your proposal looks like a constructor...

Additional the method getNestedBeanDeclaration has to be changed to use this new factory method.

[Oliver Heger]

Yes of course, this was what I had in mind.

I will have a look to integrate this feature into the next release. Thanks for the suggestion.

[Oliver Heger]

Fixed in subversion. Thanks for this suggestion.