Uploaded image for project: 'Commons Compress'
  1. Commons Compress
  2. COMPRESS-227

duplicate entries may let ZipFile#getInputStream return null

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.5
    • 1.6
    • Archivers

    Description

      Found while investigating https://issues.apache.org/bugzilla/show_bug.cgi?id=54967

      If an archive contains two entries for the same file readCentralDirectory in ZipFile will only add the first entry to the entries map and only the last to the nameMap map - this is because entries is a LinkedHashMap and nameMap is a "plain" HashMap.

      Normally this wouldn't matter since both ZipArchiveEntry instances are equal and thus it is irrelevant which of the two is used as a key when obtaining the InputStream.

      Things get different, though, if the entry has data inside the local file header as only the first entry is dealt with in resolveLocalFileHeaderData - after this the two instances are no longer equal and nameMap.get(NAME) will return an instance that can no longer be found.

      I intend to modify readCentralDirectory to only add the first entry to nameMap as well and document the behavior. I'll also start a discussion thread on the dev list on whether we need to provide an additional API with multiple entries per name.

      Attachments

        1. test.zip
          0.2 kB
          Stefan Bodewig

        Activity

          People

            bodewig Stefan Bodewig
            bodewig Stefan Bodewig
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: